From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v4, 12/16] common: env_embedded: allow fine placement of environment object
Date: Fri, 6 Apr 2018 17:03:43 -0400 [thread overview]
Message-ID: <20180406210343.GD10996@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <ae6a0c7be8e730b3fe933ce859d97e99f2ae2b08.1521215903.git.christophe.leroy@c-s.fr>
On Fri, Mar 16, 2018 at 05:20:53PM +0100, Christophe Leroy wrote:
> Commit 7653942b10e9e ("common/env_embedded.c: drop support for
> CONFIG_SYS_USE_PPCENV") dropped the .ppcenv section which was
> used in linking scripts to allow fine placement of embedded
> environment sections.
>
> This implies that GCC randomly places objects from env/embedded.o
> and environment is not guaranteed to be located at the correct address:
>
> 04003df8 g F .text 00000038 mii_init
> 04004000 g O .text 00000004 env_size
> 04004004 g O .text 00002000 environment
> 04006004 g F .text 00000040 .hidden __lshrdi3
>
> This patch restores this capability by allocating each object marked
> with __UBOOT_ENV_SECTION__ into a different section. Hence
> 'environment' will be alone in .text.environment, allowing a
> fine placement in u-boot.lds with:
>
> . = DEFINED(env_offset) ? env_offset : .;
> env/embedded.o (.text.environment)
>
> Fixes: 7653942b10e9e ("common/env_embedded.c: drop support for CONFIG_SYS_USE_PPCENV")
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180406/490be286/attachment.sig>
next prev parent reply other threads:[~2018-04-06 21:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:20 [U-Boot] [PATCH v4 00/16] Powerpc: mpc8xx: cleanup before migration to DM model Christophe Leroy
2018-03-16 16:20 ` [U-Boot] [PATCH v4 01/16] soft_i2c: cleanup - no mpc8xx support Christophe Leroy
2018-04-06 21:02 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 02/16] powerpc: mpc8xx: harmonise initialisation of the immap local pointer Christophe Leroy
2018-04-06 21:02 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 03/16] powerpc: mpc8xx: get rid of the multiple PVR_ values Christophe Leroy
2018-04-06 21:02 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 04/16] powerpc: mpc8xx: make get_immr() independent of CONFIG_8xx Christophe Leroy
2018-04-06 21:02 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 05/16] powerpc: mpc8xx: remove get_immr() argument Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 06/16] powerpc: mpc8xx: Change CONFIG_8xx to CONFIG_MPC8xx Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 07/16] powercp: mpc8xx: move commproc.h Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot,v4,07/16] " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 08/16] powerpc: mpc8xx: redistribute data in CPM dpram Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 09/16] powerpc: mpc8xx: initialisation of initial RAM Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 10/16] board: MCR3000: replace mtd->priv by mtd_to_nand() Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 11/16] board: MCR3000: cleanup config Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot,v4,11/16] " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 12/16] common: env_embedded: allow fine placement of environment object Christophe Leroy
2018-04-06 21:03 ` Tom Rini [this message]
2018-03-16 16:20 ` [U-Boot] [PATCH v4 13/16] board: MCR3000: Use smaller flash sector for environment Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 14/16] powerpc: mpc8xx: refactorise reginfo Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:20 ` [U-Boot] [PATCH v4 15/16] powerpc: mpc8xx: cleaning up watchdog Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-03-16 16:21 ` [U-Boot] [PATCH v4 16/16] powerpc: mpc8xx: move watchdog into drivers/watchdog Christophe Leroy
2018-04-06 21:03 ` [U-Boot] [U-Boot, v4, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406210343.GD10996@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox