From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 3/3] dm: led: add testcase for "default-state" property
Date: Tue, 10 Apr 2018 12:22:36 -0400 [thread overview]
Message-ID: <20180410162236.GA30642@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <20180404080103.28033-4-linux-kernel-dev@beckhoff.com>
On Wed, Apr 04, 2018 at 10:01:03AM +0200, linux-kernel-dev at beckhoff.com wrote:
> From: Patrick Bruenn <p.bruenn@beckhoff.com>
>
> Add two more gpio-leds to sandbox test device tree with default-state
> property set to "on"/"off".
> Add dm_test_led_default_state() to check that these new LED's are set to
> LEDST_ON and LEDST_OFF.
>
> Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> patman complains about: test/dm/led.c:45: check: Please use a blank line
> after function/struct/union/enum declarations.
> I compared with other DM_TEST() usage and decided to ignore this check.
> Should we fix the macro, patman or keep ignoring this?
This breaks tests actually, please try running 'make tests' after this
(and the rest of your series) is applied, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180410/c0bdbaaa/attachment.sig>
prev parent reply other threads:[~2018-04-10 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 8:01 [U-Boot] [PATCH v3 0/3] This series adds support for gpio-leds "default-state" property. The linux-kernel-dev at beckhoff.com
2018-04-04 8:01 ` [U-Boot] [PATCH v3 1/3] dm: led: Support "default-state" property linux-kernel-dev at beckhoff.com
2018-04-08 13:55 ` Simon Glass
2018-04-04 8:01 ` [U-Boot] [PATCH v3 2/3] dm: led: auto probe() LEDs with "default-state" linux-kernel-dev at beckhoff.com
2018-04-08 13:55 ` Simon Glass
2018-04-04 8:01 ` [U-Boot] [PATCH v3 3/3] dm: led: add testcase for "default-state" property linux-kernel-dev at beckhoff.com
2018-04-08 13:55 ` Simon Glass
2018-04-10 16:22 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410162236.GA30642@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox