public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ivan Gorinov <ivan.gorinov@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors
Date: Tue, 17 Apr 2018 11:29:56 -0700	[thread overview]
Message-ID: <20180417182956.GA57575@intel.com> (raw)
In-Reply-To: <CAEUhbmVmPNQU0tgsn7y29d26dr-7sZWP_50i1zXC4ozxBe7pwA@mail.gmail.com>

On Thu, Apr 05, 2018 at 09:31:34AM -0600, Bin Meng wrote:
> > The microcode update data block encoded in Device Tree is used by
> > the bootstrap processor (BSP) but not passed to the other CPUs (AP).
> 
> I don't understand what the bug is here. The AP microcode update is
> done in sipi_vector.S.

I have found how it works. When a ROM image is built, the binman tool
looks for symbol '_dt_ucode_base_size' and updates position and size
of the microcode update data in the ucode_base and ucode_size variables.
The ucode_base pointer is used to update the bootstrap CPU very early,
and the other CPUs later in the multiprocessing code.

On x86, binman is called from Makefile only if a ROM image is created:

    u-boot.rom: u-boot-x86-16bit.bin u-boot.bin \
    ...
        $(call if_changed,binman)

If there is no ROM image, ucode_base and ucode_size are not initialized and
the microcode update data from DTB applied by microcode_update_intel() to the
bootstrap CPU is not used by the multiprocessing code.

  reply	other threads:[~2018-04-17 18:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 23:07 [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors Ivan Gorinov
2018-04-05 11:07 ` Andy Shevchenko
2018-04-05 15:31 ` Bin Meng
2018-04-17 18:29   ` Ivan Gorinov [this message]
2018-04-18 12:48     ` Bin Meng
2018-04-19  0:11       ` Ivan Gorinov
2018-04-19  1:05         ` Bin Meng
2018-04-20 17:47           ` Ivan Gorinov
2018-06-12  2:05             ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417182956.GA57575@intel.com \
    --to=ivan.gorinov@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox