From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [GIT PULL] u-boot-uniphier/master
Date: Mon, 23 Apr 2018 20:34:20 -0400 [thread overview]
Message-ID: <20180424003420.GL31362@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <CAK7LNASXNLX-UAzD7VvNsoBZ=TgPxUf0hktMbyvjn3c86AO04g@mail.gmail.com>
On Tue, Apr 24, 2018 at 09:24:41AM +0900, Masahiro Yamada wrote:
> 2018-04-24 5:17 GMT+09:00 Tom Rini <trini@konsulko.com>:
> > On Tue, Apr 24, 2018 at 01:14:30AM +0900, Masahiro Yamada wrote:
> >
> >> Hi Tom,
> >>
> >> I ended up with fixing some image size problems
> >> to get my board (uniphier_v7_defconfig) back working.
> >>
> >> Please pull a little more.
> >>
> >>
> >>
> >> The following changes since commit 275d80a4c2fb63890f3f4c16b7ad481064e650a0:
> >>
> >> Merge git://git.denx.de/u-boot-usb (2018-04-22 09:30:36 -0400)
> >>
> >> are available in the git repository at:
> >>
> >> git://git.denx.de/u-boot-uniphier.git master
> >>
> >> for you to fetch changes up to 3ce5b1a8d86d46f4a390e31e52b7ba441fdb229e:
> >>
> >> ARM: uniphier: move SPL stack address (2018-04-24 00:35:35 +0900)
> >>
> >
> > Applied to u-boot/master.
> >
> > And, can you perhaps leverage CONFIG_SPL_MAX_SIZE so that in the future
> > it becomes a build-time failure when the size exceeds the limit (and I
> > can prod whomever is adding more code growth)? Thanks!
>
>
> I already have it in include/config/uniphier.h
>
>
> #define CONFIG_SPL_MAX_FOOTPRINT 0x10000
> #define CONFIG_SPL_MAX_SIZE 0x10000
>
>
> Both of them work in the linker script
> (arch/arm/cpu/u-boot-spl.lds)
>
> This check is not precise for CONFIG_SPL_OF_CONTROL.
>
> It is true that u-boot-spl-nodtb.bin is limited to 64KB,
> but I need to check the size of u-boot-spl.bin
> (SPL image with DTB appended).
>
>
> Assuming u-boot-spl.dtb is roughly 2.5 KB,
> I could do
>
>
> /* max size 64KB - DTB 2.5KB = 61.5KB */
> #define CONFIG_SPL_MAX_FOOTPRINT 0xf600
>
> But, this is not precise, and looks ugly.
>
>
> Maybe, the CONFIG_SPL_MAX_FOOTPRINT check
> should be moved to scripts/Makefile.spl
Ah. Yeah, if it makes sense to catch more cases by moving the tests out
of the linker script and into a script, we can go that direction.
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180423/6ad5e77f/attachment.sig>
next prev parent reply other threads:[~2018-04-24 0:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 16:14 [U-Boot] [GIT PULL] u-boot-uniphier/master Masahiro Yamada
2018-04-23 20:17 ` Tom Rini
2018-04-24 0:24 ` Masahiro Yamada
2018-04-24 0:34 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 11:44 Masahiro Yamada
2018-09-12 0:40 ` Tom Rini
2018-07-24 23:52 Masahiro Yamada
2018-07-26 11:13 ` Tom Rini
2018-06-22 16:36 Masahiro Yamada
2018-06-22 23:26 ` Tom Rini
2018-05-22 15:37 Masahiro Yamada
2018-05-22 22:29 ` Tom Rini
2018-05-08 1:32 Masahiro Yamada
2018-05-09 1:30 ` Tom Rini
2018-04-18 15:00 Masahiro Yamada
2018-04-19 3:14 ` Tom Rini
2018-03-15 13:53 Masahiro Yamada
2018-03-15 17:58 ` Tom Rini
2018-01-27 21:40 Masahiro Yamada
2018-01-28 2:55 ` Tom Rini
2018-01-09 13:04 Masahiro Yamada
2018-01-09 17:30 ` Tom Rini
2017-12-11 15:45 Masahiro Yamada
2017-12-12 1:55 ` Tom Rini
2017-12-04 13:23 Masahiro Yamada
2017-12-04 18:36 ` Tom Rini
2017-10-22 16:14 Masahiro Yamada
2017-10-23 16:05 ` Tom Rini
2017-10-23 17:43 ` Masahiro Yamada
2017-10-23 17:44 ` Tom Rini
2017-09-18 11:33 Masahiro Yamada
2017-09-18 21:49 ` Tom Rini
2017-08-30 0:22 Masahiro Yamada
2017-09-01 16:42 ` Tom Rini
2017-08-20 14:18 Masahiro Yamada
2017-08-22 20:53 ` Tom Rini
2017-07-26 13:56 Masahiro Yamada
2017-07-26 21:42 ` Tom Rini
2017-06-24 22:15 Masahiro Yamada
2017-06-27 17:32 ` Tom Rini
2017-05-17 13:14 Masahiro Yamada
2017-05-17 21:13 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424003420.GL31362@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox