public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Add support for Libre Computer Board ALL-H3-CC H5 ver.
Date: Tue, 24 Apr 2018 12:01:08 +0200	[thread overview]
Message-ID: <20180424100108.6vknamgqobjrfhpr@flea> (raw)
In-Reply-To: <1524561891-2704-1-git-send-email-narmstrong@baylibre.com>

On Tue, Apr 24, 2018 at 11:24:51AM +0200, Neil Armstrong wrote:
> The Libre Computer Board ALL-H3-CC from Libre Technology is a Raspberry
> Pi B+ form factor single board computer based on the Allwinner H3 or H5 SoC.
> The board has 1GB DDR3 SDRAM, provided by 4 2Gb chips. The mounting holes
> and connectors are in the exact same position as on the Raspberry Pi B+.
> 
> This patch adds defconfig and dts files for the H5 variant of the same board.
> The dts file simply includes the H3 variant since the board is the same.
> 
> The defconfig is based on the H3 variant and adapted to build for the H5.
> 
> This follows the corresponding Linux patchset at [1].
> 
> [1] http://lkml.kernel.org/r/1524561576-2201-1-git-send-email-narmstrong at baylibre.com
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Commit log should be wrapped at 75 chars.

> ---
>  arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts | 12 ++++++++++++
>  configs/libretech_all_h3_cc_h5_defconfig       | 17 +++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
>  create mode 100644 configs/libretech_all_h3_cc_h5_defconfig
> 
> diff --git a/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts b/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
> new file mode 100644
> index 0000000..a72b0a3
> --- /dev/null
> +++ b/arch/arm/dts/sun50i-h5-libretech-all-h3-cc.dts
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2018 BayLibre, SAS
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + */
> +
> +#include "sun8i-h3-libretech-all-h3-cc.dts"
> +
> +/ {
> +	model = "Libre Computer Board ALL-H3-CC H5";
> +	compatible = "libretech,all-h3-cc-h5", "allwinner,sun50i-h5";
> +};

The DT will not be correct in that case, especially the CPU node. Why
not using the same DT than Linux?

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180424/495a51b8/attachment.sig>

      reply	other threads:[~2018-04-24 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  9:24 [U-Boot] [PATCH] sunxi: Add support for Libre Computer Board ALL-H3-CC H5 ver Neil Armstrong
2018-04-24 10:01 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424100108.6vknamgqobjrfhpr@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox