From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Tue, 24 Apr 2018 21:03:11 +0200 Subject: [U-Boot] [PATCH] video-uclass: Fix logical-not-parentheses warning In-Reply-To: <1524404868-28053-1-git-send-email-trini@konsulko.com> References: <1524404868-28053-1-git-send-email-trini@konsulko.com> Message-ID: <20180424210311.13959dac@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 22 Apr 2018 09:47:48 -0400 Tom Rini trini at konsulko.com wrote: > With clang-4.0 and later we see: > warning: logical not is only applied to the left hand side of this bitwise > operator [-Wlogical-not-parentheses] > if ((!gd->flags & GD_FLG_RELOC)) > ^ ~ > > And while the compiler suggests adding parenthesis around gd->flags, a > reading of the code says that we want to know when GD_FLG_RELOC is not > set and then return. > > Cc: Simon Glass > Cc: Anatolij Gustschin > Signed-off-by: Tom Rini > --- > drivers/video/video-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-video/master, thanks! -- Anatolij