From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 25 Apr 2018 09:53:54 +0200 Subject: [U-Boot] [RFC PATCH v1 4/5] dfu: Resolve Kconfig dependency loops In-Reply-To: <1524562627-5794-5-git-send-email-alex.kiernan@gmail.com> References: <1524562627-5794-1-git-send-email-alex.kiernan@gmail.com> <1524562627-5794-5-git-send-email-alex.kiernan@gmail.com> Message-ID: <20180425095354.273493df@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alex, > Fix recursive dependencies in Kconfig introduced by fastboot UDP > > Signed-off-by: Alex Kiernan > --- > > cmd/fastboot/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/cmd/fastboot/Kconfig b/cmd/fastboot/Kconfig > index 0c57616..0f804ea 100644 > --- a/cmd/fastboot/Kconfig > +++ b/cmd/fastboot/Kconfig > @@ -2,13 +2,13 @@ comment "FASTBOOT" > > menuconfig FASTBOOT > bool "Fastboot support" > - depends on USB_GADGET > default y if ARCH_SUNXI && USB_MUSB_GADGET > > if FASTBOOT > > config USB_FUNCTION_FASTBOOT > bool "Enable USB fastboot gadget" > + depends on USB_GADGET > default y > select USB_GADGET_DOWNLOAD > imply ANDROID_BOOT_IMAGE > @@ -17,7 +17,7 @@ config USB_FUNCTION_FASTBOOT > This enables the USB part of the fastboot gadget. > > config UDP_FUNCTION_FASTBOOT > - select NET > + depends on NET > bool "Enable fastboot protocol over UDP" > help > This enables the fastboot protocol over UDP. > @@ -66,6 +66,7 @@ config FASTBOOT_BUF_SIZE > > config FASTBOOT_USB_DEV > int "USB controller number" > + depends on USB_FUNCTION_FASTBOOT > default 0 > help > Some boards have USB OTG controller other than 0. Define > this I think that it should be possible to have fastboot support enabled for both USB and ETH if a board has those interfaces present. Then by using proper commands: fastboot usb or fastboot udp we can decide which medium would be used. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: