[U-Boot] [RFC PATCH v1 1/5] dfu: Refactor fastboot_okay/fail to take response

Alex Kiernan
2018-04-25T08:10:15Z

On Wed, Apr 25, 2018 at 8:27 AM, Lukasz Majewski <lukma@denx.de> wrote:
> Hi Alex,
>
> Please change the subject prefix - i.e. dfu: is a totally different
> code.
>
> Maybe fastboot would be more appropriate?
>

Sorry, was trying to pick something in the right kind of space/known
to git-mailrc, but I'll change that.

>> Add the response string as a parameter to fastboot_okay/fail, instead
>> of modifying a global, to match the contract expected by the AOSP
>> U-Boot code.
>
> I suppose that this change is to make the u-boot mainline code matching
> the current Android?
>

Yes. When you get to the guts of it, the interface that was there, was
a bit odd - callers had to initialise the global fb_response_str
before calling into the rest of the fastboot code.

--
Alex Kiernan