From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 25 Apr 2018 09:57:21 +0200 Subject: [U-Boot] [RFC PATCH v1 0/5] Add fastboot UDP support In-Reply-To: <20180425095210.294d25af@jawa> References: <1524562627-5794-1-git-send-email-alex.kiernan@gmail.com> <20180425095210.294d25af@jawa> Message-ID: <20180425095721.22c95152@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alex, > > - the USB and UDP code want consolidating, with this series there > > would then be two separate implementations of the same protocol > > Yes - this is an issue. > > For USB the fastboot protocol (at least some its logic) is implemented > in drivers/usb/gadget/f_fastboot.c > > I think that some medium agnostic code (like protocol itself) can be > unified. > > I also think that it would be a good idea to have ./drivers/fastboot > directory introduced to move common code there - and leave only USB > related code in f_fastboot.c Especially that we do have fb_nand.c and fb_mmc.c in ./common. In that way we could move them to ./drivers/fastboot. > > Please as a reference, look on how ./drivers/dfu is organised. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: