public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 8/8] spl: disk: usb: Add dependencies to sprintf/strto*
Date: Sun, 29 Apr 2018 17:04:16 -0400	[thread overview]
Message-ID: <20180429210416.GF31362@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <1524112377-13724-9-git-send-email-alex.kiernan@gmail.com>

On Thu, Apr 19, 2018 at 04:32:57AM +0000, Alex Kiernan wrote:

> If SPL serial support is disabled nothing brings in sprintf, snprintf
> or simple_strtoul:
> 
>   env/built-in.o: In function `regex_callback':
>   env/attr.c:128: undefined reference to `sprintf'
>   disk/built-in.o: In function `blk_get_device_by_str':
>   disk/part.c:386: undefined reference to `simple_strtoul'
>   disk/part.c:395: undefined reference to `simple_strtoul'
>   disk/built-in.o: In function `blk_get_device_part_str':
>   disk/part.c:522: undefined reference to `simple_strtoul'
>   disk/built-in.o: In function `part_set_generic_name':
>   disk/part.c:704: undefined reference to `sprintf'
>   drivers/built-in.o: In function `init_peripheral_ep':
>   drivers/usb/musb-new/musb_gadget.c:1826: undefined reference to `sprintf'
>   drivers/built-in.o: In function `musb_core_init':
>   drivers/usb/musb-new/musb_core.c:1451: undefined reference to `snprintf'
> 
> Add those dependencies here.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180429/e5bb2429/attachment.sig>

      reply	other threads:[~2018-04-29 21:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  4:32 [U-Boot] [PATCH v2 0/8] Fix SPL build without CONFIG_SPL_SERIAL_SUPPORT Alex Kiernan
2018-04-19  4:32 ` [U-Boot] [PATCH v2 1/8] Cleanup CONFIG_SPL_SERIAL_SUPPORT migration Alex Kiernan
2018-04-29 21:03   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 2/8] spl: ti: Avoid preloader_console_init if !CONFIG_SPL_SERIAL_SUPPORT Alex Kiernan
2018-04-29 21:03   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 3/8] spl: Add dependency on serial to Ymodem Alex Kiernan
2018-04-29 21:03   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 4/8] spl: ti: Avoid serial calls when serial support is disabled Alex Kiernan
2018-04-29 21:03   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 5/8] spl: Split sprintf, strto* from SPL serial in Kconfig Alex Kiernan
2018-04-29 21:04   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 6/8] spl: Disable printf if not required Alex Kiernan
2018-04-29 21:04   ` [U-Boot] [U-Boot,v2,6/8] " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 7/8] Consolidate __assert_failed into one implementation Alex Kiernan
2018-04-29 21:04   ` [U-Boot] [U-Boot, v2, " Tom Rini
2018-04-19  4:32 ` [U-Boot] [PATCH v2 8/8] spl: disk: usb: Add dependencies to sprintf/strto* Alex Kiernan
2018-04-29 21:04   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180429210416.GF31362@bill-the-cat.ec.rr.com \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox