public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] image: fit: Show signatures and hashes for configurations
@ 2018-04-30  9:06 Clément Péron
  2018-05-09  1:31 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Clément Péron @ 2018-04-30  9:06 UTC (permalink / raw)
  To: u-boot

The signature/hash information are displayed for images but nor for
configurations.

Add subnodes printing in fit_conf_print() like it's done in fit_image_print()

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 common/image-fit.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/common/image-fit.c b/common/image-fit.c
index 030a3e579f..16e7858254 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -1590,6 +1590,7 @@ void fit_conf_print(const void *fit, int noffset, const char *p)
 	const char *uname;
 	int ret;
 	int fdt_index, loadables_index;
+	int ndepth;
 
 	/* Mandatory properties */
 	ret = fit_get_desc(fit, noffset, &desc);
@@ -1643,6 +1644,16 @@ void fit_conf_print(const void *fit, int noffset, const char *p)
 		}
 		printf("%s\n", uname);
 	}
+
+	/* Process all hash subnodes of the component configuration node */
+	for (ndepth = 0, noffset = fdt_next_node(fit, noffset, &ndepth);
+	     (noffset >= 0) && (ndepth > 0);
+	     noffset = fdt_next_node(fit, noffset, &ndepth)) {
+		if (ndepth == 1) {
+			/* Direct child node of the component configuration node */
+			fit_image_print_verification_data(fit, noffset, p);
+		}
+	}
 }
 
 static int fit_image_select(const void *fit, int rd_noffset, int verify)
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] image: fit: Show signatures and hashes for configurations
  2018-04-30  9:06 [U-Boot] [PATCH] image: fit: Show signatures and hashes for configurations Clément Péron
@ 2018-05-09  1:31 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-05-09  1:31 UTC (permalink / raw)
  To: u-boot

On Mon, Apr 30, 2018 at 11:06:40AM +0200, Clément Péron wrote:

> The signature/hash information are displayed for images but nor for
> configurations.
> 
> Add subnodes printing in fit_conf_print() like it's done in fit_image_print()
> 
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180508/c0c7b60a/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-09  1:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-30  9:06 [U-Boot] [PATCH] image: fit: Show signatures and hashes for configurations Clément Péron
2018-05-09  1:31 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox