From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking
Date: Wed, 2 May 2018 07:15:45 -0400 [thread overview]
Message-ID: <20180502111545.GA9026@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <20180502070815.27013-4-lukma@denx.de>
On Wed, May 02, 2018 at 09:08:11AM +0200, Lukasz Majewski wrote:
> Those two functions can be used to provide easy bootcount management.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
[snip]
> +#if defined CONFIG_SPL_BOOTCOUNT_LIMIT || defined CONFIG_BOOTCOUNT_LIMIT
> +
> #if !defined(CONFIG_SYS_BOOTCOUNT_LE) && !defined(CONFIG_SYS_BOOTCOUNT_BE)
Style problem. We have a few places where we don't use parens in the
code today, but this is the first time I've noticed and had to check
quickly to see that. Please follow the normal convention of if
defined(FOO) .... Otherwise:
Reviewed-by: Tom Rini <trini@konsulko.com>
And, erm, since you'll need to repost this one, please v5 the whole
series since you accidentally did v3 again in the subject just to make
it extra easy to see what version I should pull in later? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180502/cd219810/attachment.sig>
next prev parent reply other threads:[~2018-05-02 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 7:08 [U-Boot] [PATCH v3 0/7] Provide SPL support for bootcount (in the case of using falcon boot mode) Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 1/7] bootcount: spl: Enable bootcount support in SPL Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 2/7] bootcount: Add include guards into bootcount.h file Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking Lukasz Majewski
2018-05-02 7:19 ` Stefan Roese
2018-05-02 11:15 ` Tom Rini [this message]
2018-05-02 14:13 ` Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 4/7] bootcount: Rewrite autoboot to use wrapper functions from bootcount.h Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 5/7] bootcount: spl: Extend SPL to support bootcount incrementation Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 6/7] bootcount: display5: spl: Extend DISPLAY5 board SPL to support bootcount checking Lukasz Majewski
2018-05-02 7:08 ` [U-Boot] [PATCH v3 7/7] bootcount: display5: config: Enable boot count feature in the display5 board Lukasz Majewski
-- strict thread matches above, loose matches on Subject: below --
2018-04-29 13:36 [U-Boot] [PATCH v3 0/7] Provide SPL support for bootcount (in the case of using falcon boot mode) Lukasz Majewski
2018-04-29 13:36 ` [U-Boot] [PATCH v3 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking Lukasz Majewski
2018-04-30 8:07 ` Stefan Roese
2018-04-30 8:39 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502111545.GA9026@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox