From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 2 May 2018 07:15:45 -0400 Subject: [U-Boot] [PATCH v3 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking In-Reply-To: <20180502070815.27013-4-lukma@denx.de> References: <20180502070815.27013-1-lukma@denx.de> <20180502070815.27013-4-lukma@denx.de> Message-ID: <20180502111545.GA9026@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, May 02, 2018 at 09:08:11AM +0200, Lukasz Majewski wrote: > Those two functions can be used to provide easy bootcount management. > > Signed-off-by: Lukasz Majewski [snip] > +#if defined CONFIG_SPL_BOOTCOUNT_LIMIT || defined CONFIG_BOOTCOUNT_LIMIT > + > #if !defined(CONFIG_SYS_BOOTCOUNT_LE) && !defined(CONFIG_SYS_BOOTCOUNT_BE) Style problem. We have a few places where we don't use parens in the code today, but this is the first time I've noticed and had to check quickly to see that. Please follow the normal convention of if defined(FOO) .... Otherwise: Reviewed-by: Tom Rini And, erm, since you'll need to repost this one, please v5 the whole series since you accidentally did v3 again in the subject just to make it extra easy to see what version I should pull in later? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: