From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 2 May 2018 16:13:23 +0200 Subject: [U-Boot] [PATCH v3 3/7] bootcount: Add function wrappers to handle bootcount increment and error checking In-Reply-To: <20180502111545.GA9026@bill-the-cat.ec.rr.com> References: <20180502070815.27013-1-lukma@denx.de> <20180502070815.27013-4-lukma@denx.de> <20180502111545.GA9026@bill-the-cat.ec.rr.com> Message-ID: <20180502161323.6e7330f8@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, > On Wed, May 02, 2018 at 09:08:11AM +0200, Lukasz Majewski wrote: > > > Those two functions can be used to provide easy bootcount > > management. > > > > Signed-off-by: Lukasz Majewski > [snip] > > > +#if defined CONFIG_SPL_BOOTCOUNT_LIMIT || defined > > CONFIG_BOOTCOUNT_LIMIT + > > #if !defined(CONFIG_SYS_BOOTCOUNT_LE) > > && !defined(CONFIG_SYS_BOOTCOUNT_BE) > > Style problem. We have a few places where we don't use parens in the > code today, but this is the first time I've noticed and had to check > quickly to see that. Please follow the normal convention of if > defined(FOO) .... Otherwise: I've just sent the corrected v5 to ML. > > Reviewed-by: Tom Rini > > And, erm, since you'll need to repost this one, please v5 the whole > series since you accidentally did v3 again in the subject just to make > it extra easy to see what version I should pull in later? Thanks! > I suppose that this code shall be applied to -next anyway (as it is already too late in the current release cycle (rc3)). Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: