From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] stdio_dev.h: Drop the video section as it is unused
Date: Wed, 2 May 2018 20:32:22 -0400 [thread overview]
Message-ID: <20180503003222.GL9026@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <CALeDE9NZsVN-ge+TRqDDLfEiR9UfunvA4y1jGPUjidjccO5egQ@mail.gmail.com>
On Thu, May 03, 2018 at 12:38:34AM +0100, Peter Robinson wrote:
> On Wed, May 2, 2018 at 11:09 PM, Tom Rini <trini@konsulko.com> wrote:
> > With tighter build flags the fact that this header referenced
> > uchar/ushort without including what typedefs it causes warnings. Rather
> > than add another include here, drop the section in question as it is
> > unused.
>
> This doesn't completely fix my problem, with this patch applied I
> still get a build failure from this file this time for MAX_FILES, so
> it likely needs a "#include <stdio.h>" as well which was added via the
> include common.h in my previous patch
>
> Error was:
> /builddir/build/BUILD/u-boot-2018.05-rc3/include/stdio_dev.h:55:26:
> error: 'MAX_FILES' undeclared here (not in a function)
If you pop in stdio.h does anything else pop up? I'll do a v2 with a
separate patch to MAX_FILES / stdio_names (since a few places use 3
directly). Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180502/117cb35f/attachment.sig>
prev parent reply other threads:[~2018-05-03 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 22:09 [U-Boot] [PATCH] stdio_dev.h: Drop the video section as it is unused Tom Rini
2018-05-02 23:38 ` Peter Robinson
2018-05-03 0:32 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503003222.GL9026@bill-the-cat.ec.rr.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox