From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniu Rosca Date: Sun, 13 May 2018 22:43:56 +0200 Subject: [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4 In-Reply-To: References: <20180512171331.19693-1-erosca@de.adit-jv.com> <20180512182556.GA2025@x230> <20180512191705.GA23056@example.com> Message-ID: <20180513204335.GA27136@example.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, May 13, 2018 at 10:52:07PM +0900, Masahiro Yamada wrote: > 2018-05-13 4:17 GMT+09:00 Eugeniu Rosca : > > I wonder if Kconfig could avoid printing whitespace in command line > > user dialogs. Then maybe those space characters could be removed from > > the "*xpected_stdout" files. > > > 'make config' display a space at the end of line > when prompting user input. > > This makes the input readable, like follows: > > * > * Linux/x86 4.17.0-rc4 Kernel Configuration > * > 64-bit kernel (64BIT) [Y/n/?] y > * > * General setup > * > Cross-compiler tool prefix (CROSS_COMPILE) [] > Compile also drivers which will not load (COMPILE_TEST) [N/y/?] y > > > > I think you are suggesting to remove a space, like follows: > > * > * Linux/x86 4.17.0-rc4 Kernel Configuration > * > 64-bit kernel (64BIT) [Y/n/?]y > * > * General setup > * > Cross-compiler tool prefix (CROSS_COMPILE) [] > Compile also drivers which will not load (COMPILE_TEST) [N/y/?]y > > > I believe we should not do this > just for unit-testing. Chopped output will hurt user experience, so I agree it's not a solution to eliminate trailing whitespace in predefined stdout files for pytest. Thank you, Eugeniu.