* [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings
@ 2018-05-14 20:49 Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2018-05-14 20:49 UTC (permalink / raw)
To: u-boot
Previous attempt to fix HSYNC and VSYNC polarity settings for dw_hdmi on sunxi
wasn't completely correct - there's another bug in dw_hdmi driver.
This series fixes hsync/vsync settings in sunxi glue driver and
applies proper fix to dw_hdmi
v2: don't revert earlier fix, just use correct bits for hsync and vsync
Vasily Khoruzhick (2):
sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity.
video: dw_hdmi: fix HSYNC and VSYNC polarity settings
drivers/video/dw_hdmi.c | 4 ++--
drivers/video/sunxi/sunxi_dw_hdmi.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity.
2018-05-14 20:49 [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
@ 2018-05-14 20:49 ` Vasily Khoruzhick
2018-05-15 5:15 ` Jernej Škrabec
2018-05-14 20:49 ` [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-15 6:08 ` [U-Boot] [PATCH v2 0/2] " Anatolij Gustschin
2 siblings, 1 reply; 6+ messages in thread
From: Vasily Khoruzhick @ 2018-05-14 20:49 UTC (permalink / raw)
To: u-boot
HSYNC is bit 8, and VSYNC is bit 9.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/video/sunxi/sunxi_dw_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/sunxi_dw_hdmi.c
index c78e33b947..9dbea649a0 100644
--- a/drivers/video/sunxi/sunxi_dw_hdmi.c
+++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
@@ -303,10 +303,10 @@ static int sunxi_dw_hdmi_enable(struct udevice *dev, int panel_bpp,
sunxi_dw_hdmi_lcdc_init(priv->mux, edid, panel_bpp);
- if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW)
+ if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW)
setbits_le32(&phy->pol, 0x200);
- if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW)
+ if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW)
setbits_le32(&phy->pol, 0x100);
setbits_le32(&phy->ctrl, 0xf << 12);
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity.
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
@ 2018-05-15 5:15 ` Jernej Škrabec
0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2018-05-15 5:15 UTC (permalink / raw)
To: u-boot
Hi!
Dne ponedeljek, 14. maj 2018 ob 22:49:52 CEST je Vasily Khoruzhick napisal(a):
> HSYNC is bit 8, and VSYNC is bit 9.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
> ---
> drivers/video/sunxi/sunxi_dw_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c
> b/drivers/video/sunxi/sunxi_dw_hdmi.c index c78e33b947..9dbea649a0 100644
> --- a/drivers/video/sunxi/sunxi_dw_hdmi.c
> +++ b/drivers/video/sunxi/sunxi_dw_hdmi.c
> @@ -303,10 +303,10 @@ static int sunxi_dw_hdmi_enable(struct udevice *dev,
> int panel_bpp,
>
> sunxi_dw_hdmi_lcdc_init(priv->mux, edid, panel_bpp);
>
> - if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW)
> + if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW)
> setbits_le32(&phy->pol, 0x200);
>
> - if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW)
> + if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW)
> setbits_le32(&phy->pol, 0x100);
>
> setbits_le32(&phy->ctrl, 0xf << 12);
> --
> 2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings
2018-05-14 20:49 [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
@ 2018-05-14 20:49 ` Vasily Khoruzhick
2018-05-15 5:15 ` Jernej Škrabec
2018-05-15 6:08 ` [U-Boot] [PATCH v2 0/2] " Anatolij Gustschin
2 siblings, 1 reply; 6+ messages in thread
From: Vasily Khoruzhick @ 2018-05-14 20:49 UTC (permalink / raw)
To: u-boot
Currently dw_hdmi configures HSYNC polarity using VSYNC setting from
EDID and vice versa. Fix it, since it breaks displays where HSYNC
and VSYNC polarity differs
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/video/dw_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/dw_hdmi.c b/drivers/video/dw_hdmi.c
index dbad0e2b24..229bd63c97 100644
--- a/drivers/video/dw_hdmi.c
+++ b/drivers/video/dw_hdmi.c
@@ -401,11 +401,11 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi,
/* set up hdmi_fc_invidconf */
inv_val = HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE;
- inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
+ inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH :
HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW);
- inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
+ inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH :
HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW);
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings
2018-05-14 20:49 ` [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
@ 2018-05-15 5:15 ` Jernej Škrabec
0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2018-05-15 5:15 UTC (permalink / raw)
To: u-boot
Hi,
Dne ponedeljek, 14. maj 2018 ob 22:49:53 CEST je Vasily Khoruzhick napisal(a):
> Currently dw_hdmi configures HSYNC polarity using VSYNC setting from
> EDID and vice versa. Fix it, since it breaks displays where HSYNC
> and VSYNC polarity differs
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
> ---
> drivers/video/dw_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/dw_hdmi.c b/drivers/video/dw_hdmi.c
> index dbad0e2b24..229bd63c97 100644
> --- a/drivers/video/dw_hdmi.c
> +++ b/drivers/video/dw_hdmi.c
> @@ -401,11 +401,11 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi,
> /* set up hdmi_fc_invidconf */
> inv_val = HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE;
>
> - inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
> + inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
> HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH :
> HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW);
>
> - inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
> + inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
> HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH :
> HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW);
>
> --
> 2.17.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings
2018-05-14 20:49 [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
@ 2018-05-15 6:08 ` Anatolij Gustschin
2 siblings, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2018-05-15 6:08 UTC (permalink / raw)
To: u-boot
Hi,
On Mon, 14 May 2018 13:49:51 -0700
Vasily Khoruzhick anarsoul at gmail.com wrote:
> Previous attempt to fix HSYNC and VSYNC polarity settings for dw_hdmi on sunxi
> wasn't completely correct - there's another bug in dw_hdmi driver.
> This series fixes hsync/vsync settings in sunxi glue driver and
> applies proper fix to dw_hdmi
>
> v2: don't revert earlier fix, just use correct bits for hsync and vsync
>
> Vasily Khoruzhick (2):
> sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity.
> video: dw_hdmi: fix HSYNC and VSYNC polarity settings
>
> drivers/video/dw_hdmi.c | 4 ++--
> drivers/video/sunxi/sunxi_dw_hdmi.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Series applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-15 6:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-14 20:49 [U-Boot] [PATCH v2 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-14 20:49 ` [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity Vasily Khoruzhick
2018-05-15 5:15 ` Jernej Škrabec
2018-05-14 20:49 ` [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings Vasily Khoruzhick
2018-05-15 5:15 ` Jernej Škrabec
2018-05-15 6:08 ` [U-Boot] [PATCH v2 0/2] " Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox