From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules
Date: Tue, 15 May 2018 18:20:22 +0200 [thread overview]
Message-ID: <20180515182022.4cb88e10@xps13> (raw)
In-Reply-To: <CAPnjgZ3COuAuORV6PaOsyg8Wcoo0jdFtBoNG9OMCu_kLfgaK7g@mail.gmail.com>
Hi Simon,
On Wed, 16 May 2018 02:04:58 +1000, Simon Glass <sjg@chromium.org>
wrote:
> Hi Miquel,
>
> On 15 May 2018 at 19:57, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > Add the tpm2_tis_spi driver that should support any TPMv2 compliant
> > (SPI) module.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/tpm/Kconfig | 10 +
> > drivers/tpm/Makefile | 2 +
> > drivers/tpm/tpm2_tis_spi.c | 664 +++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 676 insertions(+)
> > create mode 100644 drivers/tpm/tpm2_tis_spi.c
> >
>
> Is there a change log for this patch?
Yes there is one in the cover letter but your are right it was not
clear enough what file I was talking about:
<snip>
> * Removed useless reset of rx_buf[0] in tpm_tis_spi_xfer().
> * Changed the way spi_xfer return code is checked: error out on any
> value != 0 instead of just negative ones.
> * Removed unused functions flagged __maybe_unused as well as well as the
> __maybe_unused flags themselves when not needed.
> * Simplified the validity check of the GPIO as suggested.
> * Updated the compatible property for the SPI modules (as well as the
> bindings docuementation) to be simply "tis,tpm2-spi" which should work
> with most compliant chips. Data is linked to this generic compatible
> in the TPM driver, other values may be added if needed in the future
> to fit other chips that would use different values than the current
> ones (used by Infineon SLB 9670 and ST ST33TPHF20 modules, for
> instance).
</snip>
Regards,
Miquèl
--
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-15 16:20 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 9:56 [U-Boot] [PATCH v4 00/32] Introduce TPMv2.0 support Miquel Raynal
2018-05-15 9:56 ` [U-Boot] [PATCH v4 01/32] tpm: remove redundant blank line Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:02 ` Simon Glass
2018-05-26 15:53 ` [U-Boot] [U-Boot,v4,01/32] " Tom Rini
2018-05-15 9:56 ` [U-Boot] [PATCH v4 02/32] tpm: remove extra spaces between a function and its opening bracket Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:02 ` Simon Glass
2018-05-26 15:53 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:56 ` [U-Boot] [PATCH v4 03/32] tpm: substitute deprecated uint<x>_t types with their u<x> equivalent Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:04 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 04/32] tpm: align arguments with open parenthesis Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:02 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 05/32] tpm: use the BIT() macro where applicable Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:03 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 06/32] tpm: fix spelling Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:03 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot,v4,06/32] " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 07/32] tpm: add extra blank lines between declarations and code Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:04 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 08/32] tpm: add Revision ID field in the chip structure Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 09/32] tpm: prepare introduction of TPMv2.x support in Kconfig Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-27 22:22 ` Miquel Raynal
2018-05-15 9:57 ` [U-Boot] [PATCH v4 10/32] tpm: disociate TPMv1.x specific and generic code Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 11/32] tpm: add missing parameter in private data structure description Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-15 16:04 ` Simon Glass
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 12/32] tpm: prepare support for TPMv2.x commands Miquel Raynal
2018-05-15 15:58 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 13/32] tpm: add macros to enhance TPM commands readability Miquel Raynal
2018-05-15 15:59 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 14/32] tpm: add possible traces to analyze buffers returned by the TPM Miquel Raynal
2018-05-15 15:59 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 15/32] tpm: report driver error code to upper layer Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:54 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 16/32] tpm: add TPM2_Startup command support Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 17/32] tpm: add TPM2_SelfTest " Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 18/32] tpm: add TPM2_Clear " Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot,v4,18/32] " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 19/32] tpm: add TPM2_PCR_Extend " Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 20/32] tpm: add TPM2_PCR_Read " Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 21/32] tpm: add TPM2_GetCapability " Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 22/32] tpm: add dictionary attack mitigation commands support Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 23/32] tpm: add TPM2_HierarchyChangeAuth command support Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 24/32] tpm: add PCR authentication commands support Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-15 16:04 ` Simon Glass
2018-05-15 16:20 ` Miquel Raynal [this message]
2018-05-15 16:26 ` Simon Glass
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 26/32] tpm: add the possibility to reset the chip with a gpio Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-15 16:05 ` Simon Glass
2018-05-15 16:32 ` Miquel Raynal
2018-05-15 17:01 ` Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 27/32] doc: device-tree-bindings: add TIS TPMv2.0 SPI module info Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 28/32] test/py: add TPMv2.x test suite Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot,v4,28/32] " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 29/32] tpm: add a Sandbox TPMv2.x driver Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:55 ` [U-Boot] [U-Boot,v4,29/32] " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 30/32] doc: device-tree-bindings: add Sandbox TPMv2.0 module info Miquel Raynal
2018-05-15 16:00 ` Tom Rini
2018-05-26 15:56 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 31/32] sandbox: dts: add Sandbox TPMv2.x node Miquel Raynal
2018-05-15 16:01 ` Tom Rini
2018-05-26 15:56 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 9:57 ` [U-Boot] [PATCH v4 32/32] configs: add TPMv2.x support in Sandbox Miquel Raynal
2018-05-15 16:01 ` Tom Rini
2018-05-26 15:56 ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-15 16:01 ` [U-Boot] [PATCH v4 00/32] Introduce TPMv2.0 support Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515182022.4cb88e10@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox