From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4
Date: Sat, 19 May 2018 14:21:25 +0200 [thread overview]
Message-ID: <20180519122125.GA18607@example.com> (raw)
In-Reply-To: <20180516112702.GA2818@vmlxhi-102.adit-jv.com>
Dear reviewers,
Please, have a look at v3 series. TIA!
Best regards,
Eugeniu.
On Wed, May 16, 2018 at 01:27:02PM +0200, Eugeniu Rosca wrote:
> Hi Petr, Masahiro, Simon,
>
> On Wed, May 16, 2018 at 10:24:41AM +0200, Eugeniu Rosca wrote:
> > Hi Petr,
> >
> > On Wed, May 16, 2018 at 07:09:05AM +0200, Petr Vorel wrote:
> > > Hi Eugeniu,
> > >
> > > > 2018-05-13 2:13 GMT+09:00 Eugeniu Rosca <roscaeugeniu@gmail.com>:
> > > > > Align Kconfig to Linux 4.17-rc4 with minimal impact on non-kconfig files.
> > >
> > > > > Previous Kconfig sync was done by commit bf7ab1e70fd762 ("kconfig:
> > > > > re-sync with Linux 4.10") and it achieved almost perfect alignment with
> > > > > a few (intended) exceptions, caused by below U-boot commits:
> > >
> > > Maybe it's again something wrong with my patch, but it broke 2 builds in travis:
> > > https://travis-ci.org/pevik/u-boot/builds/379302139
> > >
> > > It's this branch (make testconfig works on it):
> > > https://github.com/pevik/u-boot/commits/eugeniu/kconfig.v2.test
> >
> > Our branches match, so it's not the root cause this time.
> > I will start looking into this. Thanks for reporting.
> > I hope we provide a flawless Kconfig update to the users.
>
> What I see both in [1] and [2] is failure of `ut dm fdt_translation`
> unit test in sandbox/sandbox_flattree environments. I can reproduce
> it myself with the delivered patch-set (see [3]), but cannot reproduce
> it on u-boot/master.
>
> Doing basic bisecting, I can easily figure out that the issue is
> introduced by the last patch in the series, specifically commit
> ("sandbox: dts: test: Fix wrong aliases property names"). The patch
> fixing the issue is shown in [4]. The problem is no more reproduced
> afterwards, as seen in [5].
>
> Please, feedback if you are fine with this level of analysis and the
> fix itself or maybe I should go deeper with investigation.
>
> Anyway, based on above, the problem seems to be unrelated to the
> Kconfig/DTC update. Special thanks to Petr for reporting it.
>
> Best regards,
> Eugeniu.
>
> [1] https://travis-ci.org/pevik/u-boot/jobs/379302204
> [2] https://travis-ci.org/pevik/u-boot/jobs/379302206
>
> [3] Reproducing the issue seen in [1] and [2] in sandbox:
> $ ./u-boot -d arch/sandbox/dts/test.dtb
>
> U-Boot 2018.05-00230-ge8e03803af5b (May 16 2018 - 13:09:51 +0200)
>
> Model: sandbox
> DRAM: 128 MiB
> MMC: mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD)
> In: serial
> Out: vidconsole
> Err: vidconsole
> Model: sandbox
> SCSI: Net: eth0: eth at 10002000, eth5: eth at 10003000, eth3: sbe5, eth1: eth at 10004000
> IDE: Bus 0: not available
> Hit any key to stop autoboot: 0
> => ut dm fdt_translation
> Test: dm_test_fdt_translation: test-fdt.c
> test/dm/test-fdt.c:444, dm_test_fdt_translation(): 0 == uclass_find_device_by_seq(UCLASS_TEST_DUMMY, 0, 1, &dev): Expected 0, got -19
> Test: dm_test_fdt_translation: test-fdt.c (flat tree)
> test/dm/test-fdt.c:444, dm_test_fdt_translation(): 0 == uclass_find_device_by_seq(UCLASS_TEST_DUMMY, 0, 1, &dev): Expected 0, got -19
> Failures: 2
> =>
>
> [4] Patch fixing [3].
> diff --git a/test/dm/test-fdt.c b/test/dm/test-fdt.c
> index 8196844e89a7..66d0df5629a2 100644
> --- a/test/dm/test-fdt.c
> +++ b/test/dm/test-fdt.c
> @@ -425,7 +425,7 @@ static const struct udevice_id fdt_dummy_ids[] = {
> };
>
> UCLASS_DRIVER(fdt_dummy) = {
> - .name = "fdt_dummy",
> + .name = "fdt-dummy",
> .id = UCLASS_TEST_DUMMY,
> .flags = DM_UC_FLAG_SEQ_ALIAS,
> };
>
> [5] The issue is healed after applying [4]:
> $ ./u-boot -d arch/sandbox/dts/test.dtb
>
> U-Boot 2018.05-00230-ge8e03803af5b-dirty (May 16 2018 - 13:15:13 +0200)
>
> Model: sandbox
> DRAM: 128 MiB
> MMC: mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD)
> In: serial
> Out: vidconsole
> Err: vidconsole
> Model: sandbox
> SCSI: Net: eth0: eth at 10002000, eth5: eth at 10003000, eth3: sbe5, eth1: eth at 10004000
> IDE: Bus 0: not available
> Hit any key to stop autoboot: 0
> => ut dm fdt_translation
> Test: dm_test_fdt_translation: test-fdt.c
> Test: dm_test_fdt_translation: test-fdt.c (flat tree)
> Failures: 0
> =>
prev parent reply other threads:[~2018-05-19 12:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 17:13 [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4 Eugeniu Rosca
2018-05-12 17:13 ` [U-Boot] [PATCH v2 2/6] board: eets: pdu001: Fix wrong default value in Kconfig Eugeniu Rosca
2018-05-12 17:13 ` [U-Boot] [PATCH v2 3/6] scripts/dtc: Update to upstream version v1.4.5-6-gc1e55a5513e9 Eugeniu Rosca
2018-05-13 22:00 ` Simon Glass
2018-05-16 1:54 ` Masahiro Yamada
2018-05-16 11:51 ` Eugeniu Rosca
2018-05-12 17:13 ` [U-Boot] [PATCH v2 4/6] scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987 Eugeniu Rosca
2018-05-13 22:00 ` Simon Glass
2018-05-13 22:45 ` Eugeniu Rosca
2018-05-14 19:52 ` Simon Glass
2018-05-15 13:46 ` Eugeniu Rosca
2018-05-15 16:05 ` Simon Glass
2018-05-16 1:49 ` Masahiro Yamada
2018-05-12 17:13 ` [U-Boot] [PATCH v2 5/6] scripts/dtc: Re-sync with Linux 4.17-rc4 Eugeniu Rosca
2018-05-15 14:06 ` Eugeniu Rosca
2018-05-15 16:05 ` Simon Glass
2018-05-16 1:48 ` Masahiro Yamada
2018-05-12 17:13 ` [U-Boot] [PATCH v2 6/6] sandbox: dts: test: Fix wrong aliases property names Eugeniu Rosca
2018-05-13 22:00 ` Simon Glass
2018-05-12 18:25 ` [U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4 Petr Vorel
2018-05-12 19:17 ` Eugeniu Rosca
2018-05-12 19:31 ` Petr Vorel
2018-05-12 21:17 ` Eugeniu Rosca
2018-05-13 13:52 ` Masahiro Yamada
2018-05-13 20:43 ` Eugeniu Rosca
2018-05-14 19:35 ` Petr Vorel
2018-05-16 1:59 ` Masahiro Yamada
2018-05-16 5:09 ` Petr Vorel
2018-05-16 8:24 ` Eugeniu Rosca
2018-05-16 11:27 ` Eugeniu Rosca
2018-05-19 12:21 ` Eugeniu Rosca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519122125.GA18607@example.com \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox