public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alex Kiernan <alex.kiernan@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 07/18] fastboot: Fix parameter types in _fb_nand_write
Date: Thu, 24 May 2018 13:29:02 +0000	[thread overview]
Message-ID: <20180524132913.11575-8-alex.kiernan@gmail.com> (raw)
In-Reply-To: <20180524132913.11575-1-alex.kiernan@gmail.com>

Compiling on a 64 bit target the arguments to _fb_nand_write are
incompatible:

  drivers/fastboot/fb_nand.c: In function ‘_fb_nand_write’:
  drivers/fastboot/fb_nand.c:101:42: warning: passing argument 3 of ‘nand_write_skip_bad’ from incompatible pointer type [-Wincompatible-pointer-types]
    return nand_write_skip_bad(mtd, offset, &length, written,
                                          ^
  In file included from drivers/fastboot/fb_nand.c:16:0:
  include/nand.h:107:5: note: expected ‘size_t * {aka long unsigned int *}’ but argument is of type ‘unsigned int *’
   int nand_write_skip_bad(struct mtd_info *mtd, loff_t offset, size_t *length,
       ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---

Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3:
- new

Changes in v2: None

 drivers/fastboot/fb_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
index 2ee0d644e0..849a6f16a5 100644
--- a/drivers/fastboot/fb_nand.c
+++ b/drivers/fastboot/fb_nand.c
@@ -89,7 +89,7 @@ static int _fb_nand_erase(struct mtd_info *mtd, struct part_info *part)
 
 static int _fb_nand_write(struct mtd_info *mtd, struct part_info *part,
 			  void *buffer, unsigned int offset,
-			  unsigned int length, size_t *written)
+			  size_t length, size_t *written)
 {
 	int flags = WITH_WR_VERIFY;
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-24 13:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 13:28 [U-Boot] [PATCH v7 00/18] Add fastboot UDP support Alex Kiernan
2018-05-24 13:28 ` [U-Boot] [PATCH v7 01/18] fastboot: Move fastboot to drivers/fastboot Alex Kiernan
2018-05-24 13:28 ` [U-Boot] [PATCH v7 02/18] fastboot: Refactor fastboot_okay/fail to take response Alex Kiernan
2018-05-24 13:28 ` [U-Boot] [PATCH v7 03/18] fastboot: Extract fastboot_okay/fail to fb_common.c Alex Kiernan
2018-05-24 13:28 ` [U-Boot] [PATCH v7 04/18] fastboot: Correct dependencies in FASTBOOT_FLASH Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 05/18] fastboot: Add missing newlines Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 06/18] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME Alex Kiernan
2018-05-24 13:29 ` Alex Kiernan [this message]
2018-05-24 13:29 ` [U-Boot] [PATCH v7 08/18] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 09/18] fastboot: Extract common definitions from USB fastboot Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 10/18] fastboot: Rename public fb_ functions to fastboot_ Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 11/18] ti: fastboot: Move weak overrides to board files Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 12/18] fs: Add fs_get_type_name to return current filesystem name Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 13/18] fastboot: Migrate FASTBOOT_FLASH_NAND_TRIMFFS to Kconfig Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 14/18] mmc: Separate "mmc swrite" from fastboot Alex Kiernan
2018-05-25  2:41   ` Simon Glass
2018-05-25 10:02     ` Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 15/18] net: fastboot: Merge AOSP UDP fastboot Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 16/18] fastboot: Add support for 'oem format' command Alex Kiernan
2018-05-24 13:29 ` [U-Boot] [PATCH v7 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot Alex Kiernan
2018-05-25  2:41   ` Simon Glass
2018-05-24 13:29 ` [U-Boot] [PATCH v7 18/18] fastboot: Update fastboot documentation Alex Kiernan
2018-05-25  2:41   ` Simon Glass
2018-05-28  7:39 ` [U-Boot] [PATCH v7 00/18] Add fastboot UDP support Lukasz Majewski
2018-05-29 11:24   ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524132913.11575-8-alex.kiernan@gmail.com \
    --to=alex.kiernan@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox