From: Tuomas Tynkkynen <tuomas@tuxera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] rpi: Fix fdt_high & initrd_high for 64-bit builds
Date: Thu, 24 May 2018 17:57:53 +0300 [thread overview]
Message-ID: <20180524175753.5d6fac8b@duuni> (raw)
In-Reply-To: <3c4004b2-0d79-a621-7885-641ac788958b@suse.de>
Hi Alex,
On Thu, 24 May 2018 09:51:57 +0200
Alexander Graf <agraf@suse.de> wrote:
> On 20.04.18 12:03, Tuomas Tynkkynen wrote:
> > The magic value that disables relocation is dependent on the CPU word
> > size, so the current 'ffffffff' is doing the wrong thing on aarch64.
> >
> > Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
>
> The BCM283x series of SOCs is limited to 32bit address space, so I don't
> quite see why the current (int)-1 is wrong?
>
>
The comparison for the magic "don't relocate value" is done by parsing
the variable as ulong and then comparing to ~0. So on 64-bit, ffffffff
gets interpreted as literal 0xffffffff limit for the relocation (which
I think in practice is the same as not specifying initrd_high at all
since the end of DRAM is lower than that) instead.
next prev parent reply other threads:[~2018-05-24 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 15:49 [U-Boot] [PATCH] rpi: Adjust fdt_addr_r to a sane address Alexander Graf
2018-04-14 18:04 ` Tuomas Tynkkynen
2018-04-20 10:03 ` Tuomas Tynkkynen
2018-04-20 10:03 ` [U-Boot] [PATCH 1/2] rpi: Fix fdt_high & initrd_high for 64-bit builds Tuomas Tynkkynen
2018-05-24 7:51 ` Alexander Graf
2018-05-24 14:57 ` Tuomas Tynkkynen [this message]
2018-05-24 15:22 ` Alexander Graf
2018-04-20 10:03 ` [U-Boot] [PATCH 2/2] rpi: Change load addresses to make more room for the kernel & DTB Tuomas Tynkkynen
2018-04-22 19:41 ` [U-Boot] [PATCH] rpi: Adjust fdt_addr_r to a sane address Tuomas Tynkkynen
2018-05-24 8:12 ` Alexander Graf
2018-05-24 11:07 ` Tuomas Tynkkynen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524175753.5d6fac8b@duuni \
--to=tuomas@tuxera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox