From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] common: iotrace: fix behaviour when buffer is full
Date: Fri, 25 May 2018 13:41:28 +0300 [thread overview]
Message-ID: <20180525104128.7990-7-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180525104128.7990-1-ramon.fried@gmail.com>
When the buffer is full, there supposed to be no more
writes, the code however misses the else statement and
subsequently writes to arbitrary pointer location and increases
the offset.
This patch fixes that by returning immediately.
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---
common/iotrace.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/iotrace.c b/common/iotrace.c
index 74408a5dbb..5f06d2b250 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -55,6 +55,8 @@ static void add_record(int flags, const void *ptr, ulong value)
rec = (struct iotrace_record *)map_sysmem(
iotrace.start + iotrace.offset,
sizeof(value));
+ } else {
+ return;
}
rec->timestamp = get_ticks();
--
2.17.0
next prev parent reply other threads:[~2018-05-25 10:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 10:41 [U-Boot] [PATCH v2 0/6] Iotrace improvements Ramon Fried
2018-05-25 10:41 ` [U-Boot] [PATCH 1/6] cmd: iotrace: add set region command Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-25 10:41 ` [U-Boot] [PATCH 2/6] iotrace: add IO region limit Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-25 10:41 ` [U-Boot] [PATCH 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-26 6:00 ` Ramon Fried
2018-05-25 10:41 ` [U-Boot] [PATCH 4/6] iotrace: move record definitons to header file Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-25 10:41 ` [U-Boot] [PATCH v2 5/6] cmd: iotrace: add dump trace command Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-25 10:41 ` Ramon Fried [this message]
2018-05-26 2:07 ` [U-Boot] [PATCH 6/6] common: iotrace: fix behaviour when buffer is full Simon Glass
2018-05-26 6:05 ` Ramon Fried
2018-05-26 22:18 ` Simon Glass
2018-05-27 8:35 ` Ramon Fried
2018-05-28 1:45 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525104128.7990-7-ramon.fried@gmail.com \
--to=ramon.fried@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox