From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniu Rosca Date: Sat, 26 May 2018 13:04:07 +0200 Subject: [U-Boot] [PATCH v3 6/6] test: dm: Fix wrong aliases property names In-Reply-To: References: <20180519121355.18377-1-erosca@de.adit-jv.com> <20180519121355.18377-6-erosca@de.adit-jv.com> <20180524220438.GA14935@example.com> Message-ID: <20180526110407.GA19851@example.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Fri, May 25, 2018 at 08:07:37PM -0600, Simon Glass wrote: > Hi, > > On 24 May 2018 at 16:04, Eugeniu Rosca wrote: > > Besides the above, it is not clear to me if your Reviewed-by applies to > > to this patch partially (since you expressed some concerns) or applies > > globally, in which case the concerns are not major? > > It means that I've reviewed the patch and I'd like some changes, but > don't want to review it after you have made those changes, so you > should add the Reviewed-by tag when doing the next version. > > But in this case your change is correct, so please don't worry. It's > unfortunate that the uclass name needs a hypen, but I understand why. Thanks for shedding light both on technical aspects and the review process itself, which is very helpful. Regarding the state of the whole patch-set, I think we reached a point in which all the review comments have been handled. Please, let me know if you still see any open topics. Otherwise, I will be waiting for Tom's feedback and if it doesn't come in the next 1-2 weeks, I will send a friendly reminder. > Regards, > Simon Best regards, Eugeniu.