[U-Boot] [PATCH v4 25/32] tpm: add support for TPMv2.x SPI modules

Simon Glass
2018-05-15T16:26:41Z

On 16 May 2018 at 02:20, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Simon,
>
> On Wed, 16 May 2018 02:04:58 +1000, Simon Glass <sjg@chromium.org>
> wrote:
>
>> Hi Miquel,
>>
>> On 15 May 2018 at 19:57, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>> > Add the tpm2_tis_spi driver that should support any TPMv2 compliant
>> > (SPI) module.
>> >
>> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> > ---
>> > drivers/tpm/Kconfig | 10 +
>> > drivers/tpm/Makefile | 2 +
>> > drivers/tpm/tpm2_tis_spi.c | 664 +++++++++++++++++++++++++++++++++++++++++++++
>> > 3 files changed, 676 insertions(+)
>> > create mode 100644 drivers/tpm/tpm2_tis_spi.c
>> >
>>
>> Is there a change log for this patch?
>
> Yes there is one in the cover letter but your are right it was not
> clear enough what file I was talking about:
>
> <snip>
>> * Removed useless reset of rx_buf[0] in tpm_tis_spi_xfer().
>> * Changed the way spi_xfer return code is checked: error out on any
>> value != 0 instead of just negative ones.
>> * Removed unused functions flagged __maybe_unused as well as well as the
>> __maybe_unused flags themselves when not needed.
>> * Simplified the validity check of the GPIO as suggested.
>> * Updated the compatible property for the SPI modules (as well as the
>> bindings docuementation) to be simply "tis,tpm2-spi" which should work
>> with most compliant chips. Data is linked to this generic compatible
>> in the TPM driver, other values may be added if needed in the future
>> to fit other chips that would use different values than the current
>> ones (used by Infineon SLB 9670 and ST ST33TPHF20 modules, for
>> instance).
> </snip>

Thanks!

Reviewed-by: Simon Glass <sjg@chromium.org>