public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] inappropriate PCI configuration on arm64 qemu?
Date: Mon, 28 May 2018 16:59:06 +0900	[thread overview]
Message-ID: <20180528075905.GF30789@linaro.org> (raw)

When I tried to add a SD card to qemu's virt machine (2.10.0) as,
	------
        -device sdhci-pci \
        -device sd-card,drive=my_sd \
        -drive if=none,id=my_sd,format=raw,file=/path/my/sd.img
	------
u-boot doesn't configure a SDHCI controller properly and an attached
device is never detected.

Digging into the code, I found
* reading BAR5 in dm_pciauto_setup_device() shows BAR5 is a 32-bit address,
* pciauto_region_allocate() allocates a 64-bit address (0x80.ABCD.0000)
  to BAR5 as res->bus_lower is 0x80.0000.0000
* Upper 32-bit value is not written back to BAR5 because of !found_mem64
  (BAR5 is the last one and no succeeding BAR anyway.)

On the other hand,
* Qemu defines two PCI memory regions for MMIO:
        (from qemu's hw/arm/virt.c)
	------
	[VIRT_PCIE_MMIO] =          { 0x10000000, 0x2eff0000 },
	[VIRT_PCIE_PIO] =           { 0x3eff0000, 0x00010000 },
	[VIRT_PCIE_ECAM] =          { 0x3f000000, 0x01000000 },
	[VIRT_MEM] =                { 0x40000000, RAMLIMIT_BYTES },
	/* Second PCIe window, 512GB wide at the 512GB boundary */
	[VIRT_PCIE_MMIO_HIGH] =   { 0x8000000000ULL, 0x8000000000ULL },
	------
* A PCI card is configured in decode_regions() so that
  'hose' has only one entry per each type of memory regions.
  This behavior was introduced by Simon's patch:
	------
	commit 9526d83ac5a
	Author: Simon Glass <sjg@chromium.org>
	Date:   Thu Nov 19 20:26:58 2015 -0700

	    dm: pci: Support decoding ranges with duplicate entries
	------
* As a result, MMIO region (0x1000.0000-0x2eff.0000) is overwritten
  and MMIO_HIGH is the only one available at runtime.

I believe that this behavior is the root cause of my issue, and
by reverting the patch mentioned above, everything works fine.

While I understand a concern mentioned in the commit message,
there should be a better way to manage the case.

Any ideas?

Thanks,
-Takahiro AKASHI

             reply	other threads:[~2018-05-28  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28  7:59 AKASHI Takahiro [this message]
2018-05-30 19:18 ` [U-Boot] inappropriate PCI configuration on arm64 qemu? Simon Glass
2018-05-31  5:05   ` AKASHI Takahiro
2018-05-31 10:32     ` Tuomas Tynkkynen
2018-06-01  7:21       ` AKASHI Takahiro
2018-06-01 10:20         ` Tuomas Tynkkynen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528075905.GF30789@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox