public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/6] common: iotrace: add timestamp to iotrace records
Date: Wed, 30 May 2018 23:09:59 +0300	[thread overview]
Message-ID: <20180530201002.31913-4-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180530201002.31913-1-ramon.fried@gmail.com>

Add timestamp to each iotrace record to aid in debugging
of IO timing access bugs.

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4: None
Changes in v3: None
Changes in v2: None
Changes in v1:
- Change timestamp function to get_ticks()

 common/iotrace.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/iotrace.c b/common/iotrace.c
index f39885663a..2f03a6082e 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -27,11 +27,13 @@ enum iotrace_flags {
  * struct iotrace_record - Holds a single I/O trace record
  *
  * @flags: I/O access type
+ * @timestamp: Timestamp of access
  * @addr: Address of access
  * @value: Value written or read
  */
 struct iotrace_record {
 	enum iotrace_flags flags;
+	u64 timestamp;
 	phys_addr_t addr;
 	iovalue_t value;
 };
@@ -81,7 +83,7 @@ static void add_record(int flags, const void *ptr, ulong value)
 					iotrace.start + iotrace.offset,
 					sizeof(value));
 	}
-
+	rec->timestamp = timer_get_us();
 	rec->flags = flags;
 	rec->addr = map_to_sysmem(ptr);
 	rec->value = value;
-- 
2.17.0

  parent reply	other threads:[~2018-05-30 20:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 20:09 [U-Boot] [PATCH v4 0/6] Iotrace improvements Ramon Fried
2018-05-30 20:09 ` [U-Boot] [PATCH v4 1/6] cmd: iotrace: add set region command Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot,v4,1/6] " Tom Rini
2018-05-30 20:09 ` [U-Boot] [PATCH v4 2/6] iotrace: add IO region limit Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot,v4,2/6] " Tom Rini
2018-05-30 20:09 ` Ramon Fried [this message]
2018-06-08 11:19   ` [U-Boot] [U-Boot, v4, 3/6] common: iotrace: add timestamp to iotrace records Tom Rini
2018-05-30 20:10 ` [U-Boot] [PATCH v4 4/6] iotrace: move record definitons to header file Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-06-08 12:49     ` Ramon Fried
2018-06-08 13:24       ` Ramon Fried
2018-05-30 20:10 ` [U-Boot] [PATCH v4 5/6] cmd: iotrace: add dump trace command Ramon Fried
2018-06-08 11:18   ` [U-Boot] [U-Boot,v4,5/6] " Tom Rini
2018-06-08 14:55     ` Ramon Fried
2018-05-30 20:10 ` [U-Boot] [PATCH v4 6/6] iotrace: fix behaviour when buffer is full Ramon Fried
2018-05-31 13:01   ` Simon Glass
2018-05-31 15:06     ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530201002.31913-4-ramon.fried@gmail.com \
    --to=ramon.fried@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox