public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 5/6] cmd: iotrace: add dump trace command
Date: Wed, 30 May 2018 23:10:01 +0300	[thread overview]
Message-ID: <20180530201002.31913-6-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180530201002.31913-1-ramon.fried@gmail.com>

Add dump trace command which dump all trace
buffer content in a much more readable fashion
than md.

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None
Changes in v1: None

 cmd/iotrace.c | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/cmd/iotrace.c b/cmd/iotrace.c
index 601b8c8e32..f50a3c3a1a 100644
--- a/cmd/iotrace.c
+++ b/cmd/iotrace.c
@@ -24,6 +24,36 @@ static void do_print_stats(void)
 	printf("CRC32:  %08lx\n", (ulong)iotrace_get_checksum());
 }
 
+static void do_print_trace(void)
+{
+	ulong start, size, offset, count;
+
+	struct iotrace_record *cur_record;
+
+	iotrace_get_buffer(&start, &size, &offset, &count);
+
+	if (!start || !size || !count)
+		return;
+
+	printf("Timestamp  Value          Address\n");
+
+	cur_record = (struct iotrace_record *)start;
+	for (int i = 0; i < count; i++) {
+		if (cur_record->flags & IOT_WRITE)
+			printf("%08llu: 0x%08lx --> 0x%08lx\n",
+			       cur_record->timestamp,
+					cur_record->value,
+					cur_record->addr);
+		else
+			printf("%08llu: 0x%08lx <-- 0x%08lx\n",
+			       cur_record->timestamp,
+					cur_record->value,
+					cur_record->addr);
+
+		cur_record++;
+	}
+}
+
 static int do_set_buffer(int argc, char * const argv[])
 {
 	ulong addr = 0, size = 0;
@@ -76,6 +106,9 @@ int do_iotrace(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	case 's':
 		do_print_stats();
 		break;
+	case 'd':
+		do_print_trace();
+		break;
 	default:
 		return CMD_RET_USAGE;
 	}
@@ -90,5 +123,6 @@ U_BOOT_CMD(
 	"iotrace buffer <address> <size>      - set iotrace buffer\n"
 	"iotrace limit <address> <size>       - set iotrace region limit\n"
 	"iotrace pause                        - pause tracing\n"
-	"iotrace resume                       - resume tracing"
+	"iotrace resume                       - resume tracing\n"
+	"iotrace dump                         - dump iotrace buffer"
 );
-- 
2.17.0

  parent reply	other threads:[~2018-05-30 20:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 20:09 [U-Boot] [PATCH v4 0/6] Iotrace improvements Ramon Fried
2018-05-30 20:09 ` [U-Boot] [PATCH v4 1/6] cmd: iotrace: add set region command Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot,v4,1/6] " Tom Rini
2018-05-30 20:09 ` [U-Boot] [PATCH v4 2/6] iotrace: add IO region limit Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot,v4,2/6] " Tom Rini
2018-05-30 20:09 ` [U-Boot] [PATCH v4 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-05-30 20:10 ` [U-Boot] [PATCH v4 4/6] iotrace: move record definitons to header file Ramon Fried
2018-06-08 11:19   ` [U-Boot] [U-Boot, v4, " Tom Rini
2018-06-08 12:49     ` Ramon Fried
2018-06-08 13:24       ` Ramon Fried
2018-05-30 20:10 ` Ramon Fried [this message]
2018-06-08 11:18   ` [U-Boot] [U-Boot,v4,5/6] cmd: iotrace: add dump trace command Tom Rini
2018-06-08 14:55     ` Ramon Fried
2018-05-30 20:10 ` [U-Boot] [PATCH v4 6/6] iotrace: fix behaviour when buffer is full Ramon Fried
2018-05-31 13:01   ` Simon Glass
2018-05-31 15:06     ` Ramon Fried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530201002.31913-6-ramon.fried@gmail.com \
    --to=ramon.fried@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox