From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: env: Use getline rather than fgets when reading config/script
Date: Thu, 7 Jun 2018 14:26:17 +0200 [thread overview]
Message-ID: <20180607142617.74a529ef@jawa> (raw)
In-Reply-To: <20180607122005.17506-1-alex.kiernan@gmail.com>
On Thu, 7 Jun 2018 12:20:05 +0000
Alex Kiernan <alex.kiernan@gmail.com> wrote:
> When reading the config file, or a script file, use getline rather
> than fgets so line lengths aren't limited by the size of a compiled
> in buffer (128 characters for config, 1024 for scripts).
>
> Rename 'dump' to 'line' so it's clear we're working with a line of
> text.
Reviwed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180607/c3dfd109/attachment.sig>
next prev parent reply other threads:[~2018-06-07 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 12:20 [U-Boot] [PATCH] tools: env: Use getline rather than fgets when reading config/script Alex Kiernan
2018-06-07 12:26 ` Lukasz Majewski [this message]
2018-06-13 15:42 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607142617.74a529ef@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox