public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/6] iotrace: move record definitons to header file
Date: Fri,  8 Jun 2018 20:53:25 +0300	[thread overview]
Message-ID: <20180608175327.9097-5-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180608175327.9097-1-ramon.fried@gmail.com>

The header definitions are needed for reading
record information in cmd/iotrace.c

Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v5:
- Removed common.h include that caused werid compliation problems
in other boards (trini)

Changes in v4: None
Changes in v3: None
Changes in v2: None
Changes in v1: None

 common/iotrace.c  | 27 ---------------------------
 include/iotrace.h | 28 ++++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 27 deletions(-)

diff --git a/common/iotrace.c b/common/iotrace.c
index 2f03a6082e..83691b1dba 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -11,33 +11,6 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-/* Support up to the machine word length for now */
-typedef ulong iovalue_t;
-
-enum iotrace_flags {
-	IOT_8 = 0,
-	IOT_16,
-	IOT_32,
-
-	IOT_READ = 0 << 3,
-	IOT_WRITE = 1 << 3,
-};
-
-/**
- * struct iotrace_record - Holds a single I/O trace record
- *
- * @flags: I/O access type
- * @timestamp: Timestamp of access
- * @addr: Address of access
- * @value: Value written or read
- */
-struct iotrace_record {
-	enum iotrace_flags flags;
-	u64 timestamp;
-	phys_addr_t addr;
-	iovalue_t value;
-};
-
 /**
  * struct iotrace - current trace status and checksum
  *
diff --git a/include/iotrace.h b/include/iotrace.h
index 1efb117343..063371f23f 100644
--- a/include/iotrace.h
+++ b/include/iotrace.h
@@ -6,8 +6,36 @@
 #ifndef __IOTRACE_H
 #define __IOTRACE_H
 
+//#include <common.h>
 #include <linux/types.h>
 
+/* Support up to the machine word length for now */
+typedef ulong iovalue_t;
+
+enum iotrace_flags {
+	IOT_8 = 0,
+	IOT_16,
+	IOT_32,
+
+	IOT_READ = 0 << 3,
+	IOT_WRITE = 1 << 3,
+};
+
+/**
+ * struct iotrace_record - Holds a single I/O trace record
+ *
+ * @flags: I/O access type
+ * @timestamp: Timestamp of access
+ * @addr: Address of access
+ * @value: Value written or read
+ */
+struct iotrace_record {
+	enum iotrace_flags flags;
+	u64 timestamp;
+	phys_addr_t addr;
+	iovalue_t value;
+};
+
 /*
  * This file is designed to be included in arch/<arch>/include/asm/io.h.
  * It redirects all IO access through a tracing/checksumming feature for
-- 
2.17.1

  parent reply	other threads:[~2018-06-08 17:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 17:53 [U-Boot] [PATCH v5 0/6] Iotrace improvements Ramon Fried
2018-06-08 17:53 ` [U-Boot] [PATCH v5 1/6] cmd: iotrace: add set region command Ramon Fried
2018-06-19 18:41   ` [U-Boot] [U-Boot,v5,1/6] " Tom Rini
2018-06-08 17:53 ` [U-Boot] [PATCH v5 2/6] iotrace: add IO region limit Ramon Fried
2018-06-19 18:41   ` [U-Boot] [U-Boot,v5,2/6] " Tom Rini
2018-06-08 17:53 ` [U-Boot] [PATCH v5 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
2018-06-19 18:41   ` [U-Boot] [U-Boot, v5, " Tom Rini
2018-06-08 17:53 ` Ramon Fried [this message]
2018-06-19 18:41   ` [U-Boot] [U-Boot, v5, 4/6] iotrace: move record definitons to header file Tom Rini
2018-06-08 17:53 ` [U-Boot] [PATCH v5 5/6] cmd: iotrace: add dump trace command Ramon Fried
2018-06-19 18:41   ` [U-Boot] [U-Boot,v5,5/6] " Tom Rini
2018-06-21 15:11     ` Alexander Graf
2018-06-21 15:20       ` Tom Rini
2018-06-21 15:26         ` Alexander Graf
2018-06-08 17:53 ` [U-Boot] [PATCH v5 6/6] iotrace: fix behaviour when buffer is full Ramon Fried
2018-06-19 18:41   ` [U-Boot] [U-Boot, v5, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180608175327.9097-5-ramon.fried@gmail.com \
    --to=ramon.fried@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox