public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE
@ 2018-06-08  7:10 Alex Kiernan
  2018-06-08 21:59 ` Simon Glass
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alex Kiernan @ 2018-06-08  7:10 UTC (permalink / raw)
  To: u-boot

If ENV_IS_IN_EXT4 is set you shouldn't be able to select ENV_IS_NOWHERE.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---

 env/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/env/Kconfig b/env/Kconfig
index f403906b6f..c1d6a9ab57 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -3,6 +3,7 @@ menu "Environment"
 config ENV_IS_NOWHERE
 	bool "Environment is not stored"
 	depends on !ENV_IS_IN_EEPROM
+	depends on !ENV_IS_IN_EXT4
 	depends on !ENV_IS_IN_FAT
 	depends on !ENV_IS_IN_FLASH
 	depends on !ENV_IS_IN_MMC
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE
  2018-06-08  7:10 [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE Alex Kiernan
@ 2018-06-08 21:59 ` Simon Glass
  2018-06-09  9:15 ` Petr Vorel
  2018-06-13 15:43 ` [U-Boot] " Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2018-06-08 21:59 UTC (permalink / raw)
  To: u-boot

On 7 June 2018 at 23:10, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> If ENV_IS_IN_EXT4 is set you shouldn't be able to select ENV_IS_NOWHERE.
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
>
>  env/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE
  2018-06-08  7:10 [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE Alex Kiernan
  2018-06-08 21:59 ` Simon Glass
@ 2018-06-09  9:15 ` Petr Vorel
  2018-06-13 15:43 ` [U-Boot] " Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2018-06-09  9:15 UTC (permalink / raw)
  To: u-boot

Hi Alex,

> If ENV_IS_IN_EXT4 is set you shouldn't be able to select ENV_IS_NOWHERE.

> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Nice fix, thanks :)

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE
  2018-06-08  7:10 [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE Alex Kiernan
  2018-06-08 21:59 ` Simon Glass
  2018-06-09  9:15 ` Petr Vorel
@ 2018-06-13 15:43 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2018-06-13 15:43 UTC (permalink / raw)
  To: u-boot

On Fri, Jun 08, 2018 at 07:10:27AM +0000, Alex Kiernan wrote:

> If ENV_IS_IN_EXT4 is set you shouldn't be able to select ENV_IS_NOWHERE.
> 
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Petr Vorel <petr.vorel@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180613/1566c492/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-13 15:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08  7:10 [U-Boot] [PATCH] env: Add !ENV_IS_IN_EXT4 dependency to ENV_IS_NOWHERE Alex Kiernan
2018-06-08 21:59 ` Simon Glass
2018-06-09  9:15 ` Petr Vorel
2018-06-13 15:43 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox