[U-Boot] [PATCH 2/4] soc: qualcomm: Add Shared Memory Manager driver

Ramon Fried
2018-06-09T10:29:51Z

On Sat, Jun 9, 2018 at 1:12 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> On 06/09/2018 01:06 PM, Ramon Fried wrote:
>> The Shared Memory Manager driver implements an interface for allocating
>> and accessing items in the memory area shared among all of the
>> processors in a Qualcomm platform.
>>
>> Adapted from the Linux driver (4.17)
>
> Please, run scripts/checkpatch on this patch an fix all errors and
> warnings, e.g.
Hi Heinrich,
Actually I did run it, and I also run it in Linux and got the same results.
I thought it will be better to keep the driver aligned to Linux than
to fix these warnings.
But if can surely fix it, what do you suggest ?

>
> WARNING: line over 80 characters
> #1064: FILE: drivers/soc/qualcomm/smem.c:846:
> + smem->regions[i].virt_base = devm_ioremap(dev, r.start,
> fdt_resource_size(&r));
>
> CHECK: Alignment should match open parenthesis
> #1098: FILE: drivers/soc/qualcomm/smem.c:880:
> + if (num_regions > 1 && (ret = qcom_smem_map_memory(smem, dev,
> + "qcom,rpm-msg-ram", 1)))
>
> Do not use DOS line endings.
Sure. Thanks.
>
> Best regards
>
> Heinrich Schuchardt