From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 12 Jun 2018 13:17:16 +0200 Subject: [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster() In-Reply-To: <20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec~08nSs2JOq1074810748epcas1p32@epcas1p3.samsung.com> References: <20180604114556epcas1p373ba4abe43a2441abc99c8c17a757aec~08nSs2JOq1074810748epcas1p32@epcas1p3.samsung.com> Message-ID: <20180612131716.2ca1f153@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Seung-Woo, > After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector > <-> cluster conversions"), it is hung up writing new file to FAT16 > disk with more than 19 files in armv7. It is because result value > of sect_to_cluster() is not proper by casting from signed value to > unsigned value. Fix the wrong casting of sect_to_cluster(). > > Reported-by: Jaehoon Chung > Signed-off-by: Seung-Woo Kim > --- > include/fat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/fat.h b/include/fat.h > index 7dada41..09e1423 100644 > --- a/include/fat.h > +++ b/include/fat.h > @@ -180,7 +180,7 @@ static inline u32 clust_to_sect(fsdata *fsdata, > u32 clust) return fsdata->data_begin + clust * fsdata->clust_size; > } > > -static inline u32 sect_to_clust(fsdata *fsdata, u32 sect) > +static inline u32 sect_to_clust(fsdata *fsdata, int sect) > { > return (sect - fsdata->data_begin) / fsdata->clust_size; > } Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: