* [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster()
2018-06-04 11:45 ` [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster() Seung-Woo Kim
@ 2018-06-04 21:58 ` Tom Rini
2018-06-05 4:31 ` Seung-Woo Kim
2018-06-12 11:17 ` Lukasz Majewski
2018-06-13 15:42 ` [U-Boot] " Tom Rini
2 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2018-06-04 21:58 UTC (permalink / raw)
To: u-boot
On Mon, Jun 04, 2018 at 08:45:54PM +0900, Seung-Woo Kim wrote:
> After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector
> <-> cluster conversions"), it is hung up writing new file to FAT16
> disk with more than 19 files in armv7. It is because result value
> of sect_to_cluster() is not proper by casting from signed value to
> unsigned value. Fix the wrong casting of sect_to_cluster().
>
> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> include/fat.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Can you please also update test/fs-test.sh with a testcase for this?
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180604/93cef429/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster()
2018-06-04 21:58 ` Tom Rini
@ 2018-06-05 4:31 ` Seung-Woo Kim
0 siblings, 0 replies; 5+ messages in thread
From: Seung-Woo Kim @ 2018-06-05 4:31 UTC (permalink / raw)
To: u-boot
Hello,
On 2018년 06월 05일 06:58, Tom Rini wrote:
> On Mon, Jun 04, 2018 at 08:45:54PM +0900, Seung-Woo Kim wrote:
>
>> After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector
>> <-> cluster conversions"), it is hung up writing new file to FAT16
>> disk with more than 19 files in armv7. It is because result value
>> of sect_to_cluster() is not proper by casting from signed value to
>> unsigned value. Fix the wrong casting of sect_to_cluster().
>>
>> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
>> ---
>> include/fat.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Can you please also update test/fs-test.sh with a testcase for this?
> Thanks!
>
The simple test way is doing fat-write more than 20 files with long file
name to FAT16 image.
For example, in my armv7 odroid-xu3 target with empty fat16 root,
writing like following:
fatwrite mmc 0 13000000 01000000000000000000 4
fatwrite mmc 0 13000000 02000000000000000000 4
..
fatwrite mmc 0 13000000 21000000000000000000 4
and then 22th writing was failed like following:
ODROID-XU3 # fatwrite mmc 0 13000000 22000000000000000000 4
writing 22000000000000000000
Error: Invalid FAT entry: 0x3ffffffa
Invalid FAT entry
Error: Invalid FAT entry: 0x3ffffffa
I tested same thing with sandbox u-boot on x86, there was no error like
armv7. So, I am not sure it is helpful to add testcase for this.
Best Regards,
- Seung-Woo Kim
--
Seung-Woo Kim
Samsung Research
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster()
2018-06-04 11:45 ` [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster() Seung-Woo Kim
2018-06-04 21:58 ` Tom Rini
@ 2018-06-12 11:17 ` Lukasz Majewski
2018-06-13 15:42 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2018-06-12 11:17 UTC (permalink / raw)
To: u-boot
Hi Seung-Woo,
> After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector
> <-> cluster conversions"), it is hung up writing new file to FAT16
> disk with more than 19 files in armv7. It is because result value
> of sect_to_cluster() is not proper by casting from signed value to
> unsigned value. Fix the wrong casting of sect_to_cluster().
>
> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> include/fat.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/fat.h b/include/fat.h
> index 7dada41..09e1423 100644
> --- a/include/fat.h
> +++ b/include/fat.h
> @@ -180,7 +180,7 @@ static inline u32 clust_to_sect(fsdata *fsdata,
> u32 clust) return fsdata->data_begin + clust * fsdata->clust_size;
> }
>
> -static inline u32 sect_to_clust(fsdata *fsdata, u32 sect)
> +static inline u32 sect_to_clust(fsdata *fsdata, int sect)
> {
> return (sect - fsdata->data_begin) / fsdata->clust_size;
> }
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180612/620bc4ed/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] fs: fat: fix wrong casting to unsigned value of sect_to_cluster()
2018-06-04 11:45 ` [U-Boot] [PATCH] fs: fat: fix wrong casting to unsigned value of sect_to_cluster() Seung-Woo Kim
2018-06-04 21:58 ` Tom Rini
2018-06-12 11:17 ` Lukasz Majewski
@ 2018-06-13 15:42 ` Tom Rini
2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2018-06-13 15:42 UTC (permalink / raw)
To: u-boot
On Mon, Jun 04, 2018 at 08:45:54PM +0900, Seung-Woo Kim wrote:
> After the commit 265edc03d5a1 ("fs/fat: Clean up open-coded sector
> <-> cluster conversions"), it is hung up writing new file to FAT16
> disk with more than 19 files in armv7. It is because result value
> of sect_to_cluster() is not proper by casting from signed value to
> unsigned value. Fix the wrong casting of sect_to_cluster().
>
> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> Reviewed-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180613/bebff14d/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread