public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/11] efi_loader: Use map_sysmem() in bootefi command
Date: Thu, 14 Jun 2018 20:22:25 +0200	[thread overview]
Message-ID: <20180614182232.78201-5-agraf@suse.de> (raw)
In-Reply-To: <20180614182232.78201-1-agraf@suse.de>

The bootefi command gets a few addresses as values passed in. In sandbox,
these values are in U-Boot address space, so we need to make sure we
explicitly call map_sysmem() on them to be able to access them.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 cmd/bootefi.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index f55a40dc84..a86a2bd4a9 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -14,6 +14,7 @@
 #include <errno.h>
 #include <linux/libfdt.h>
 #include <linux/libfdt_env.h>
+#include <mapmem.h>
 #include <memalign.h>
 #include <asm/global_data.h>
 #include <asm-generic/sections.h>
@@ -389,7 +390,8 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	unsigned long addr;
 	char *saddr;
 	efi_status_t r;
-	void *fdt_addr;
+	unsigned long fdt_addr;
+	void *fdt;
 
 	/* Allow unaligned memory access */
 	allow_unaligned();
@@ -406,11 +408,12 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return CMD_RET_USAGE;
 
 	if (argc > 2) {
-		fdt_addr = (void *)simple_strtoul(argv[2], NULL, 16);
+		fdt_addr = simple_strtoul(argv[2], NULL, 16);
 		if (!fdt_addr && *argv[2] != '0')
 			return CMD_RET_USAGE;
 		/* Install device tree */
-		r = efi_install_fdt(fdt_addr);
+		fdt = map_sysmem(fdt_addr, 0);
+		r = efi_install_fdt(fdt);
 		if (r != EFI_SUCCESS) {
 			printf("ERROR: failed to install device tree\n");
 			return CMD_RET_FAILURE;
@@ -429,7 +432,7 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 			addr = simple_strtoul(saddr, NULL, 16);
 		else
 			addr = CONFIG_SYS_LOAD_ADDR;
-		memcpy((char *)addr, __efi_helloworld_begin, size);
+		memcpy(map_sysmem(addr, size), __efi_helloworld_begin, size);
 	} else
 #endif
 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
@@ -475,7 +478,7 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	}
 
 	printf("## Starting EFI application at %08lx ...\n", addr);
-	r = do_bootefi_exec((void *)addr, bootefi_device_path,
+	r = do_bootefi_exec(map_sysmem(addr, 0), bootefi_device_path,
 			    bootefi_image_path);
 	printf("## Application terminated, r = %lu\n",
 	       r & ~EFI_ERROR_MASK);
-- 
2.12.3

  parent reply	other threads:[~2018-06-14 18:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 18:22 [U-Boot] [PATCH v2 00/11] sandbox: efi_loader support Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 01/11] efi: sandbox: Add distroboot support Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 02/11] efi: sandbox: Add relocation constants Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 03/11] efi_loader: Use compiler constants for image loader Alexander Graf
2018-06-14 19:01   ` Simon Glass
2018-06-14 18:22 ` Alexander Graf [this message]
2018-06-14 19:00   ` [U-Boot] [PATCH v2 04/11] efi_loader: Use map_sysmem() in bootefi command Simon Glass
2018-06-14 18:22 ` [U-Boot] [PATCH v2 05/11] efi.h: Do not use config options Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 06/11] efi_loader: Allow SMBIOS tables in highmem Alexander Graf
2018-06-14 19:01   ` Simon Glass
2018-06-14 19:13     ` Alexander Graf
2018-06-14 19:26       ` Heinrich Schuchardt
2018-06-14 19:34         ` Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 07/11] sandbox: Map host memory for efi_loader Alexander Graf
2018-06-14 19:02   ` Simon Glass
2018-06-14 19:15     ` Alexander Graf
2018-06-14 21:36       ` Simon Glass
2018-06-14 19:21     ` Heinrich Schuchardt
2018-06-14 21:35       ` Simon Glass
2018-06-14 18:22 ` [U-Boot] [PATCH v2 08/11] efi_loader: efi_allocate_pages is too restrictive Alexander Graf
2018-06-14 18:22 ` [U-Boot] [PATCH v2 09/11] efi_loader: Disable miniapps on sandbox Alexander Graf
2018-06-14 19:01   ` Simon Glass
2018-06-14 18:22 ` [U-Boot] [PATCH v2 10/11] efi_loader: Pass address to fs_read() Alexander Graf
2018-06-14 19:01   ` Simon Glass
2018-06-14 19:51     ` Alexander Graf
2018-06-14 21:35       ` Simon Glass
2018-06-14 21:55         ` Alexander Graf
2018-06-19 22:03           ` Simon Glass
2018-06-20  9:31             ` Alexander Graf
2018-06-21  2:02               ` Simon Glass
2018-06-14 18:22 ` [U-Boot] [PATCH v2 11/11] efi: sandbox: Enable EFI loader for sandbox Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614182232.78201-5-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox