From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 04/17] efi_loader: Use map_sysmem() in bootefi command
Date: Fri, 15 Jun 2018 14:42:16 +0200 [thread overview]
Message-ID: <20180615124229.35310-5-agraf@suse.de> (raw)
In-Reply-To: <20180615124229.35310-1-agraf@suse.de>
The bootefi command gets a few addresses as values passed in. In sandbox,
these values are in U-Boot address space, so we need to make sure we
explicitly call map_sysmem() on them to be able to access them.
Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
cmd/bootefi.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index f55a40dc84..a86a2bd4a9 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -14,6 +14,7 @@
#include <errno.h>
#include <linux/libfdt.h>
#include <linux/libfdt_env.h>
+#include <mapmem.h>
#include <memalign.h>
#include <asm/global_data.h>
#include <asm-generic/sections.h>
@@ -389,7 +390,8 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
unsigned long addr;
char *saddr;
efi_status_t r;
- void *fdt_addr;
+ unsigned long fdt_addr;
+ void *fdt;
/* Allow unaligned memory access */
allow_unaligned();
@@ -406,11 +408,12 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return CMD_RET_USAGE;
if (argc > 2) {
- fdt_addr = (void *)simple_strtoul(argv[2], NULL, 16);
+ fdt_addr = simple_strtoul(argv[2], NULL, 16);
if (!fdt_addr && *argv[2] != '0')
return CMD_RET_USAGE;
/* Install device tree */
- r = efi_install_fdt(fdt_addr);
+ fdt = map_sysmem(fdt_addr, 0);
+ r = efi_install_fdt(fdt);
if (r != EFI_SUCCESS) {
printf("ERROR: failed to install device tree\n");
return CMD_RET_FAILURE;
@@ -429,7 +432,7 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
addr = simple_strtoul(saddr, NULL, 16);
else
addr = CONFIG_SYS_LOAD_ADDR;
- memcpy((char *)addr, __efi_helloworld_begin, size);
+ memcpy(map_sysmem(addr, size), __efi_helloworld_begin, size);
} else
#endif
#ifdef CONFIG_CMD_BOOTEFI_SELFTEST
@@ -475,7 +478,7 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
}
printf("## Starting EFI application at %08lx ...\n", addr);
- r = do_bootefi_exec((void *)addr, bootefi_device_path,
+ r = do_bootefi_exec(map_sysmem(addr, 0), bootefi_device_path,
bootefi_image_path);
printf("## Application terminated, r = %lu\n",
r & ~EFI_ERROR_MASK);
--
2.12.3
next prev parent reply other threads:[~2018-06-15 12:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 12:42 [U-Boot] [PATCH v3 00/17] sandbox: efi_loader support Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 01/17] efi: sandbox: Add distroboot support Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 02/17] efi: sandbox: Add relocation constants Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 03/17] efi_loader: Use compiler constants for image loader Alexander Graf
2018-06-15 12:42 ` Alexander Graf [this message]
2018-06-15 12:42 ` [U-Boot] [PATCH v3 05/17] efi.h: Do not use config options Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 06/17] efi_loader: Allow SMBIOS tables in highmem Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 07/17] sandbox: Map host memory for efi_loader Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 08/17] efi_loader: efi_allocate_pages is too restrictive Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 09/17] efi_loader: Disable miniapps on sandbox Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 10/17] fs: Convert fs_read/write to take buffer instead of address Alexander Graf
2018-06-15 14:24 ` Simon Glass
2018-06-15 14:30 ` Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 11/17] efi_loader: Introduce ms abi vararg helpers Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 12/17] efi: sandbox: Enable EFI loader for sandbox Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 13/17] sandbox: Enable 1:1 map Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 14/17] distro: Move to compiler based target architecture determination Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 15/17] efi_loader: " Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 16/17] sandbox: Allow to execute from RAM Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 17/17] sandbox: Fix setjmp/longjmp Alexander Graf
2018-06-15 15:18 ` [U-Boot] [PATCH v3 00/17] sandbox: efi_loader support Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615124229.35310-5-agraf@suse.de \
--to=agraf@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox