public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/17] efi_loader: efi_allocate_pages is too restrictive
Date: Fri, 15 Jun 2018 14:42:20 +0200	[thread overview]
Message-ID: <20180615124229.35310-9-agraf@suse.de> (raw)
In-Reply-To: <20180615124229.35310-1-agraf@suse.de>

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

When running on the sandbox the stack is not necessarily at a higher memory
address than the highest free memory.

There is no reason why the checking of the highest memory address should be
more restrictive for EFI_ALLOCATE_ANY_PAGES than for
EFI_ALLOCATE_MAX_ADDRESS.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
[agraf: use -1ULL instead]
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 lib/efi_loader/efi_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index ec66af98ea..ce29bcc6a3 100644
--- a/lib/efi_loader/efi_memory.c
+++ b/lib/efi_loader/efi_memory.c
@@ -295,7 +295,7 @@ efi_status_t efi_allocate_pages(int type, int memory_type,
 	switch (type) {
 	case EFI_ALLOCATE_ANY_PAGES:
 		/* Any page */
-		addr = efi_find_free_memory(len, gd->start_addr_sp);
+		addr = efi_find_free_memory(len, -1ULL);
 		if (!addr) {
 			r = EFI_NOT_FOUND;
 			break;
-- 
2.12.3

  parent reply	other threads:[~2018-06-15 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 12:42 [U-Boot] [PATCH v3 00/17] sandbox: efi_loader support Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 01/17] efi: sandbox: Add distroboot support Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 02/17] efi: sandbox: Add relocation constants Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 03/17] efi_loader: Use compiler constants for image loader Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 04/17] efi_loader: Use map_sysmem() in bootefi command Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 05/17] efi.h: Do not use config options Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 06/17] efi_loader: Allow SMBIOS tables in highmem Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 07/17] sandbox: Map host memory for efi_loader Alexander Graf
2018-06-15 12:42 ` Alexander Graf [this message]
2018-06-15 12:42 ` [U-Boot] [PATCH v3 09/17] efi_loader: Disable miniapps on sandbox Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 10/17] fs: Convert fs_read/write to take buffer instead of address Alexander Graf
2018-06-15 14:24   ` Simon Glass
2018-06-15 14:30     ` Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 11/17] efi_loader: Introduce ms abi vararg helpers Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 12/17] efi: sandbox: Enable EFI loader for sandbox Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 13/17] sandbox: Enable 1:1 map Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 14/17] distro: Move to compiler based target architecture determination Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 15/17] efi_loader: " Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 16/17] sandbox: Allow to execute from RAM Alexander Graf
2018-06-15 12:42 ` [U-Boot] [PATCH v3 17/17] sandbox: Fix setjmp/longjmp Alexander Graf
2018-06-15 15:18 ` [U-Boot] [PATCH v3 00/17] sandbox: efi_loader support Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615124229.35310-9-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox