From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 18 Jun 2018 12:59:03 -0400 Subject: [U-Boot] [PATCH] usb: sunxi: ohci: make ohci_t the first member in private data In-Reply-To: References: <20180617161342.19228-1-anarsoul@gmail.com> <082e3114-8207-4137-e59f-71956bf4d0d9@denx.de> Message-ID: <20180618165903.GF4609@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jun 18, 2018 at 11:45:23AM +0530, Jagan Teki wrote: > On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut wrote: > > On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote: > >> ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be > >> the first member in private data struct. > >> > >> Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code") > >> > >> Signed-off-by: Vasily Khoruzhick > > > > Sigh, I really wonder how (or if at all!) the original series was > > tested. And then I get flak for scrutinizing patches, right ... > > APAIK, I did basic sanity with possible tests. > > But one thing for sure is, you should have to wait for sometime to > apply this patch. Applying fast (that to during weekend) making > reviewers or maintainers not giving enough room to work. It is a custodian's job to pick up what they see as obviously correct and/or important fixes ASAP. While things are working in your test cases, there are clearly other hardware combinations that are not working and that this corrects. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: