public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Makefile: Ensure we build with -std=gnu11
Date: Wed, 20 Jun 2018 07:30:21 -0400	[thread overview]
Message-ID: <20180620113021.GS4609@bill-the-cat.ec.rr.com> (raw)
In-Reply-To: <5fc4cdd0a345b399f50ada59b9c0d0b6694162b4.camel@infinera.com>

On Wed, Jun 20, 2018 at 07:28:15AM +0000, Joakim Tjernlund wrote:

> On Tue, 2018-06-19 at 23:57 -0400, Tom Rini wrote:
> > 
> > 
> > With the move to using at least gcc-6 for many targets we now have C
> > code that requires the GNU11 C standard to be used in all cases.
> 
> Requiring gcc-6 is a bit much I think, there are lots of cross gcc's out there
> that is older. I don't think even the kernel needs gcc-6

We've required gcc-6 for ARM since v2018.01, and we were warning about
that for a while longer than that, due to toolchain issues.

That said, my commit message is clearly not clear enough.  We don't
require gcc-6 for everyone, we require support for -std=gnu11, and that
goes back a long ways.  It's just that since some platforms require
gcc-6 we've started having (and this is good, the code is cleaner!) some
C-11'isms sneak into the code.  For example, sandbox now fails to
compile on older hosts due to a for (int i = 0; ...) in cmd/iotrace.c

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180620/eda026ab/attachment.sig>

  reply	other threads:[~2018-06-20 11:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  3:57 [U-Boot] [PATCH] Makefile: Ensure we build with -std=gnu11 Tom Rini
2018-06-20  7:28 ` Joakim Tjernlund
2018-06-20 11:30   ` Tom Rini [this message]
2018-06-21 18:21 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620113021.GS4609@bill-the-cat.ec.rr.com \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox