From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 20 Jun 2018 07:30:21 -0400 Subject: [U-Boot] [PATCH] Makefile: Ensure we build with -std=gnu11 In-Reply-To: <5fc4cdd0a345b399f50ada59b9c0d0b6694162b4.camel@infinera.com> References: <1529467051-18964-1-git-send-email-trini@konsulko.com> <5fc4cdd0a345b399f50ada59b9c0d0b6694162b4.camel@infinera.com> Message-ID: <20180620113021.GS4609@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 20, 2018 at 07:28:15AM +0000, Joakim Tjernlund wrote: > On Tue, 2018-06-19 at 23:57 -0400, Tom Rini wrote: > > > > > > With the move to using at least gcc-6 for many targets we now have C > > code that requires the GNU11 C standard to be used in all cases. > > Requiring gcc-6 is a bit much I think, there are lots of cross gcc's out there > that is older. I don't think even the kernel needs gcc-6 We've required gcc-6 for ARM since v2018.01, and we were warning about that for a while longer than that, due to toolchain issues. That said, my commit message is clearly not clear enough. We don't require gcc-6 for everyone, we require support for -std=gnu11, and that goes back a long ways. It's just that since some platforms require gcc-6 we've started having (and this is good, the code is cleaner!) some C-11'isms sneak into the code. For example, sandbox now fails to compile on older hosts due to a for (int i = 0; ...) in cmd/iotrace.c -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: