From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 27 Jun 2018 13:07:11 -0400 Subject: [U-Boot] [PATCH 1/1] dwc2 USB controller hangs with lan78xx In-Reply-To: <5d688157-3fc1-32ee-d654-f216722a64cf@suse.de> References: <1529348166-130059-1-git-send-email-andrew.thomas@oracle.com> <1529348166-130059-2-git-send-email-andrew.thomas@oracle.com> <61fbb1a4-abf4-19d1-2bf7-8970e770124e@oracle.com> <5d688157-3fc1-32ee-d654-f216722a64cf@suse.de> Message-ID: <20180627170711.GL4609@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 27, 2018 at 06:45:39PM +0200, Alexander Graf wrote: > On 06/26/2018 08:57 PM, andrew thomas wrote: > >On 06/26/2018 05:34 AM, Alexander Graf wrote: > >>On 06/21/2018 10:37 AM, Peter Robinson wrote: > >>>On Mon, Jun 18, 2018 at 7:56 PM, Andrew Thomas > >>> wrote: > >>>>This bug is the combination of dwc2 USB controller and lan78xx > >>>>USB ethernet controller, which is the combination in use on > >>>>the Raspberry Pi Model 3 B+. > >>>> > >>>>When the host attempts to receive a packet, but a packet has not > >>>>arrived, the lan78xx controller responds by setting BIR > >>>>(Bulk-In Empty Response) to NAK. Unfortunately, this hangs > >>>>the USB controller and requires the USB controller to > >>>>be reset. > >>>> > >>>>The fix proposed is to have the lan78xx controller respond > >>>>by setting BIR to ZLP. > >>>> > >>>>Signed-off-by: Andrew Thomas > >>>Tested-by: Peter Robinson > >>> > >>>Tested on the RPi 3B+ and certainly improves this situation a number > >>>of Fedora users have seen. > >> > >> > >>What exactly have you tested? > >> > >>Even with this patch, I am not reliably to reliably boot into grub. > > > >Can you say which version of grub? > > I actually see the same effect on an old RPi3 B, so it's not lan7x specific. > We also have the exact same fix for the old 100Mbit/s LAN adapter, so I > think this fix is certainly moving us into the right direction. > > Reviewed-by: Alexander Graf > > Tom, can you please pull it in for 2018.07 still? Do you have anything else Pi-related to go in? If not, I'll grab it directly, otherwise send me a PR, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: