From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Gorinov Date: Thu, 28 Jun 2018 14:06:52 -0700 Subject: [U-Boot] [PATCH v3] x86: Use microcode update from device tree for all processors In-Reply-To: References: <1529640976-28040-1-git-send-email-bmeng.cn@gmail.com> Message-ID: <20180628210652.GA19749@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jun 26, 2018 at 03:47:49PM +0800, Bin Meng wrote: > Hi Ivan, > > On Fri, Jun 22, 2018 at 12:13 PM, Bin Meng wrote: > > Hi Ivan, > > > > On Fri, Jun 22, 2018 at 12:16 PM, Bin Meng wrote: > >> From: Ivan Gorinov > >> > >> Built without a ROM image with FSP (u-boot.rom), the U-Boot loader applies > >> the microcode update data block encoded in Device Tree to the bootstrap > >> processor but not passed to the other CPUs when multiprocessing is enabled. > >> > >> If the bootstrap processor successfully performs a microcode update > >> from Device Tree, use the same data block for the other processors. > >> > >> Signed-off-by: Ivan Gorinov > >> Reviewed-by: Bin Meng > >> [bmeng: fixed build errors on edison and qemu-x86] > >> Signed-off-by: Bin Meng > >> > >> --- > >> > >> Changes in v3: > >> - don't change arch/x86/cpu/i386/cpu.c to fix build errors on edison and > >> qemu-x86 > >> > > > > I don't think the update to arch/x86/cpu/i386/cpu.c in previous > > version is needed as mp_params.microcode_pointer is not needed during > > the MP boot. Please test this patch to see if it works on your board. > > > >> arch/x86/cpu/intel_common/car.S | 2 ++ > >> arch/x86/cpu/intel_common/microcode.c | 10 +++++++--- > >> arch/x86/include/asm/microcode.h | 1 + > >> arch/x86/lib/fsp/fsp_car.S | 4 +++- > >> 4 files changed, 13 insertions(+), 4 deletions(-) > > Did you get a chance to test this? If no issue, I will take this patch > for v2018.07. No issues. Thank you!