From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi: omap3: fix claim/release bus within DM
Date: Thu, 28 Jun 2018 17:52:41 -0400 [thread overview]
Message-ID: <20180628215241.GD18596@bill-the-cat> (raw)
In-Reply-To: <3a71532c-924b-b12e-3e50-bc24a6b23aff@schmelzer.or.at>
On Thu, Jun 28, 2018 at 10:37:10PM +0200, Hannes Schmelzer wrote:
>
> On 06/28/2018 04:26 PM, Jagan Teki wrote:
> >On Tue, Jun 26, 2018 at 7:38 PM, Hannes Schmelzer <oe5hpm@oevsv.at> wrote:
> >>The claim/release bus function must not reset the whole SPI core because
> >>settings regarding wordlen, clock-frequency and so on made by
> >>set_wordlen, set_mode, set_speed get lost with this action. Resulting in
> >>a non-functional SPI.
> >>
> >>Without DM the failure didn't came up since after the spi_reset within
> >>claim bus all the setup (wordlen, mode, ...) was called, in DM they are
> >>called by the spi uclass.
> >>
> >>We change now the things as following for having a working SPI instance
> >>in DM:
> >>
> >>- move the spi_reset(...) to the probe call in DM for having a known
> >>hardware state after probe. Without DM we don't have a probe call, so we
> >>issue the reset as before during the claim_bus call.
> >>
> >>- in release bus we just reset the modulctrl to the reset-value (spi-
> >>slave)
> >>
> >>Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at>
> >>
> >>---
> >Applied to u-boot-spi/master
> do we have a chance to get into rc3 with this?
I would like to see this and the other fixes in for that, yes, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180628/cb6e7553/attachment.sig>
prev parent reply other threads:[~2018-06-28 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 14:08 [U-Boot] [PATCH] spi: omap3: fix claim/release bus within DM Hannes Schmelzer
2018-06-27 11:53 ` Jagan Teki
2018-06-27 19:57 ` Hannes Schmelzer
2018-06-28 14:26 ` Jagan Teki
2018-06-28 20:37 ` Hannes Schmelzer
2018-06-28 21:52 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628215241.GD18596@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox