[U-Boot] [PATCH 0/7] Improve rockusb support in U-Boot

Lukasz Majewski
2018-07-05T09:07:09Z

Hi Alberto,

> Dear Kever,
>
> On Thu, Jul 5, 2018 at 3:15 AM, Kever Yang
> <kever.yang@rock-chips.com> wrote:
> >
> > Hi Alberto,
> >
> > Thanks for your patches, and I'm so glad for people using
> > rockusb and try to improve it.
> >
> > You can reference to rockchip source code here:
> > https://github.com/rockchip-linux/u-boot/blob/release/drivers/usb/gadget/f_rockusb.c
> >
> > We use msc as base framework instead of dfu because of the big
> > performance improvement, and the cmd handling part will be the
> > same.
>
>
> Don't know if injecting rockusb protocol in f_mass_storage.c will be
> acceptable in terms of coexistence and maintainability of resulting
> f_mass_storage.c

I would like to have the rockchip part separate to be included by
enabling Kconfig option in u-boot.

> Do you plan to upstream your tree?
>
> I saw patches in your tree and resulting f_rockusb.c is more clear
> yes. But we pay the price in f_mass_storage.c.

It would be nice to see the code posted on u-boot ML.

>
> Best Regards,
> Alberto Panizzo
>
> --
> Amarula Solutions SRL Via le Canevare 30 31100
> Treviso Italy Amarula Solutions BV Cruquiuskade 47
> Amsterdam 1018 AM The Netherlands Phone. +31(0)851119171 Fax.
> +31(0)204106211 www.amarulasolutions.com
>
> >
> >
> > PS: Yes, rockusb is available for all Rockchip's SoCs.
> >
> > Thanks,
> > - Kever
> > On 07/04/2018 03:02 AM, Alberto Panizzo wrote:
> > > rockusb protocol has been introduced by Eddie Cai in U-Boot
> > > mainline allowing to write internal eMMC of RK3288 based boards
> > > (and potentially all other Rockchip's CPUs).
> > >
> > > On workstation side the open source project rkdeveloptool do
> > > implement the rockusb protocol. You can find it on GitHub here:
> > > https://github.com/rockchip-linux/rkdeveloptool
> > >
> > > This patchset increase the supported functionalities on target
> > > side allowing developers to:
> > > - Read flash: rl command of rkdeveloptool
> > > - Read chip version: rci command of rkdeveloptool
> > > - Complete the write cycle implementing block erase
> > > - Improve read/write speed
> > >
> > > Alberto Panizzo (7):
> > > usb: rockchip: fix command failed on host side due to missing
> > > data usb: rockchip: implement skeleton for K_FW_GET_CHIP_VER
> > > command rockchip: rk3288: implement reading chip version from
> > > bootrom code usb: rockchip: implement K_FW_LBA_READ_10 command
> > > usb: rockchip: implement K_FW_LBA_ERASE_10 command
> > > usb: rockchip: be quiet on serial port while transferring data
> > > usb: rockchip: boost up write speed from 4MB/s to 15MB/s
> > >
> > > arch/arm/include/asm/arch-rockchip/f_rockusb.h | 6 +-
> > > arch/arm/mach-rockchip/rk3288/Makefile | 1 +
> > > arch/arm/mach-rockchip/rk3288/rockusb_rk3288.c | 30 ++++
> > > drivers/usb/gadget/f_rockusb.c | 225
> > > ++++++++++++++++++++++++- 4 files changed, 253 insertions(+), 9
> > > deletions(-) create mode 100644
> > > arch/arm/mach-rockchip/rk3288/rockusb_rk3288.c
> >
> >

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180705/76d69d0c/attachment.sig>