[U-Boot] [PATCH 6/7] usb: rockchip: be quiet on serial port while transferring data

Alberto Panizzo
2018-07-04T13:44:35Z

Hi Lukasz
On Tue, Jul 03, 2018 at 11:49:16PM +0200, Lukasz Majewski wrote:
> Hi Alberto,
>
> > While downloading or uploading megabytes of data we had thousands of
> > dummy lines like:
> >
> > transfer 0x10000 bytes done
> > OR
> > Uploading 0x1000 bytes
> >
> > even on non-debug builds. This because transfers are chunked and
> > code running on target does not have any clue about when the current
> > chunk is the last one.
>
> Is there any other indication to show if the board is still working?
>
> Something like '........................' present in fastboot?
>

No there is no other indication on board side, but workstation side
will print percentage of complete.
Since chunks are small and all chunks will feedback success or error,
on workstation you'll have clear view about board frozen or transfer
failed. On board side errors will be prompted.

Fastboot is different: workstation tool do just download data
which is buffered in memory and than flashed. Workstation than
obtain a result at the end of the process, so an indication about things
are proceeding is than really useful.

Best Regards,

Alberto Panizzo

--
Presidente CDA
Amarula Solutions SRL Via le Canevare 30 31100 Treviso Italy
CTO - Co-Founder
Amarula Solutions BV Cruquiuskade 47 Amsterdam 1018 AM The Netherlands
Phone. +31(0)851119171 Fax. +31(0)204106211 www.amarulasolutions.com

> >
> > Signed-off-by: Alberto Panizzo <alberto@amarulasolutions.com>
> > ---
> > drivers/usb/gadget/f_rockusb.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/f_rockusb.c
> > b/drivers/usb/gadget/f_rockusb.c index 230fbec..4fc8484 100644
> > --- a/drivers/usb/gadget/f_rockusb.c
> > +++ b/drivers/usb/gadget/f_rockusb.c
> > @@ -501,7 +501,7 @@ static void tx_handler_ul_image(struct usb_ep
> > *ep, struct usb_request *req) memcpy(in_req->buf, rbuffer,
> > transfer_size); in_req->length = transfer_size;
> > in_req->complete = tx_handler_ul_image;
> > - printf("Uploading 0x%x bytes\n", transfer_size);
> > + debug("Uploading 0x%x bytes\n", transfer_size);
> > usb_ep_dequeue(rockusb_func->in_ep, in_req);
> > ret = usb_ep_queue(rockusb_func->in_ep, in_req, 0);
> > if (ret)
> > @@ -563,7 +563,7 @@ static void rx_handler_dl_image(struct usb_ep
> > *ep, struct usb_request *req) req->complete = rx_handler_command;
> > req->length = EP_BUFFER_SIZE;
> > f_rkusb->buf = f_rkusb->buf_head;
> > - printf("transfer 0x%x bytes done\n",
> > f_rkusb->dl_size);
> > + debug("transfer 0x%x bytes done\n",
> > f_rkusb->dl_size); f_rkusb->dl_size = 0;
> > rockusb_tx_write_csw(f_rkusb->tag, 0, CSW_GOOD,
> > USB_BULK_CS_WRAP_LEN);
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de