From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] tpm TIS TPMv2.0
Date: Fri, 13 Jul 2018 21:30:28 +0200 [thread overview]
Message-ID: <20180713213028.33aae919@xps13> (raw)
In-Reply-To: <CD66EE5B80A65C4A89E8DE986277AC94200D73AA@depoiy0mx08mbx2.emea.avnet.com>
Hi Martin,
> > > > > Is there any specific reason why the new tpm2_tis_spi_xfer doesn't
> > > > support full duplex? It seems we did some work in parallel but you
> > > > sent the patches earlier. Is that codes tested against an existing
> > > > TPM v2? I have a working implementation what runs on SLB9670 including
> > full duplex.
> > > >
> > > > What do you mean exactly?
> > > >
> > > > I don't think the TPM2 protocol makes real use of full-duplex unless
> > > > for the wait state between the host command and the actual xfer.
> > >
> > > You are right, TIS 1.3 FIFO doesn’t use full duplex in physical level. What I
> > mean is that the driver you just wrote doesn't use the xfer function in that
> > way that you can specify in and out parameters at same time. I did this in my
> > implementation what gave me an easy chance to control the CS# of the TPM.
> >
> > Do you need this CS# handling for more advanced features? Same question
> > for the in/out xfers?
> >
> > > Can you tell me on what TPM did you test? For the SLB9670 the code
> > > doesn't work on my hardware.
> >
> > I tested with a ST33TPHF20 SPI TPM.
> >
> > I'm surprised it did not work with an SLB9670, I don't see anything in the spec
> > explaining this CS# specificity.
>
> The CS# may controls an internal state machine and the SLB9670 uses that signal.
> >
> > > For the code you wrote I'm considering to add a few lines to control
> > > the CS# in that way how my xfer is doing this for the SLB9670.
> >
> > Yes please, share the patch and add me in cc so I could test it with mine.
> Fine, will do so soon.
What's the status of this? I did not spot any patches, maybe you
forgot to copy me? Otherwise do you still plan to share the changes?
That would be great!
Thanks,
Miquèl
next prev parent reply other threads:[~2018-07-13 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 13:34 [U-Boot] tpm TIS TPMv2.0 Hecht, Martin
2018-06-18 8:04 ` Miquel Raynal
2018-06-18 8:20 ` Hecht, Martin
2018-06-18 8:43 ` Miquel Raynal
2018-06-18 9:13 ` Hecht, Martin
2018-06-18 9:21 ` Miquel Raynal
2018-06-18 9:29 ` Hecht, Martin
2018-06-18 9:34 ` Miquel Raynal
2018-06-18 9:38 ` Hecht, Martin
2018-06-18 9:47 ` Miquel Raynal
2018-06-19 22:03 ` Simon Glass
2018-06-20 8:16 ` Hecht, Martin
2018-07-13 19:30 ` Miquel Raynal [this message]
2018-07-14 13:04 ` Hecht, Martin
2018-07-14 13:10 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713213028.33aae919@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox