[U-Boot] [PATCH] sandbox_flattree: Switch to TPMv2 support

Simon Glass
2018-06-01T15:25:19Z

+Miquel due to sandbox TPM issue

Hi Tom,

On 25 May 2018 at 06:27, Tom Rini <trini@konsulko.com> wrote:
> In order to have the test.py tests for TPMv2 run automatically we need
> to have one of our sandbox builds use TPMv2 rather than TPMv1. Switch
> sandbox_flattree over to this style of TPM.

The problem seems to be that the sandbox driver is only built with
either TPMv1 or TPMv2. It needs to be able to build with both, so we
can run tests with both.

It really doesn't make any sense to have build-time branches for sandbox.

We currently have:

sandbox - should be used for most tests
sandbox64 - special build that forces a 64-bit host
sandbox_flattree - builds with dev_read_...() functions defined as
inline. We need this build so that we can test those inline functions,
and we cannot build with both the inline functions and the non-inline
functions since they are named the same
sandbox_noblk - builds without CONFIG_BLK, which means the legacy
block drivers are used. We cannot use both the legacy and driver-model
block drivers since they implement the same functions
sandbox_spl - builds sandbox with SPL support, so you can run
spl/u-boot-spl and it will start up and then load ./u-boot. We could
probably remove this and add SPL support to the vanilla sandbox build,
since people can still run ./u-boot directly

At present there are unnecessary config differences between these
builds. This is explained by the fact that it is a pain for people to
have to add configs separately to each defconfig. But we should
probably make them more common. I will take a look.

What do you think about dropping sandbox_spl and make sandbox build
SPL? It does take slightly longer to build, perhaps 25%.

>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> I'm tempted to switch the main sandbox target over instead as I don't
> quite see where we're running the tpm1.x tests automatically. Would
> that be a better idea?
> ---

Miquel, can we adjust the code to build both TPMv1 and v2 for sandbox,
and select at run-time?

> configs/sandbox_flattree_defconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Regards,
Simon