[U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

Wolfgang Denk
2018-07-19T19:52:39Z

Dear Sam,

In message <CAKaJLVuxoS0mz9pDDYqmqomsSfd83kSed=LZ261=wfUUC-Q-Xw@mail.gmail.com> you wrote:
>
> Also, I figured how to do prefixing (to display MMC errors as nested
> w.r.t. "Loading environment), without adding new field to gd. We can
> just add some new GD_LG_ and print prefix when it's installed. I'm
> gonna send new RFC soon. Please let me know what you think about [1].

This is IMO a totally wrong approach. We don't want to add more
code (and more output) jsut to paper over inconsistent error
reporting. This problem should be fixed at the root cause, i. e.
we should report errors where they are detected, and only once.
If all callers can rely that, in the error path, their callees which
return error codes, have already printed appropriate messages, there
is no need to print even more lines.

What we need is not fancy code, but consistent (and consequent)
error handling.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One day," said a dull voice from down below, "I'm going to be back
in form again and you're going to be very sorry you said that. For a
very long time. I might even go so far as to make even more Time just
for you to be sorry in." - Terry Pratchett, _Small Gods_