[U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

Tom Rini
2018-07-19T12:52:30Z

On Wed, Jul 18, 2018 at 04:09:33PM +0200, Wolfgang Denk wrote:
> Dear Tom,
>
> In message <20180718125351.GE4609@bill-the-cat> you wrote:
> >
> > > Loading Environment from FAT...
> > > --> MMC: no card present
> > > --> ** Bad device mmc 0 **
> > > --> Failed (-5)
> > > Loading Environment from MMC...
> > > --> OK
> > >
> > > instead of:
> > >
> > > Loading Environment from FAT... MMC: no card present
> > > ** Bad device mmc 0 **
> > > Failed (-5)
> > > Loading Environment from MMC... OK
> >
> > So, I think maybe (and given Wolfgang's comments) we should think about
> > how the output might want to look, and how to get there without GD
> > changes. Perhaps:
> > Attempting to load Environment from FAT (do we have more easily
> > available info at this point?):
> > MMC: no card present
> > ** Bad device mmc 0 **
> > Failed (-5)
> > Loading Environment from MMC...
> > Attempting to load Environment from MMC:
> > Succeeded
>
> Just my 0.02â‚¬:
>
> In the non-error case, the output should be a single (ideally short)
> line.
>
> Rationale: to many lines of ourput clutter your screen and make you
> miss context faster; to many/long lines take time to print so they
> make booting slower.
>
> In the error case, the user should be able to understand what the
> problem was and decide if it was critical or can be ignored (like
> here when intentionally booting without SDCard).

I understand, but I don't know if we can get there still. The problem
is we don't know if we've succeeded until we've done the relevant
probing and that in turn is what's breaking the single line, and got us
to where we are now.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180719/5878a7ad/attachment.sig>