From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 1/2] env: Drop error messages when loading environment
Date: Wed, 18 Jul 2018 08:51:05 -0400 [thread overview]
Message-ID: <20180718125105.GD4609@bill-the-cat> (raw)
In-Reply-To: <20180718061950.6BDAA240133@gemini.denx.de>
On Wed, Jul 18, 2018 at 08:19:50AM +0200, Wolfgang Denk wrote:
> Dear Sam,
>
> In message <20180717220912.11358-1-semen.protsenko@linaro.org> you wrote:
> > This is just a draft to discuss ideas related to "Make U-Boot log great
> > again" thread.
> >
> > With this patch we will have something like this:
> >
> > Loading Environment from FAT... Failed (-5)
> > Loading Environment from MMC... OK
> >
> > instead of this:
> >
> > Loading Environment from FAT... MMC: no card present
> > ** Bad device mmc 0 **
> > Failed (-5)
> > Loading Environment from MMC... OK
>
> Why do you think an error message "Failed (-5)" looks great?
>
> From a user's point of view, the "MMC: no card present"
> is _much_ better (but of course it could still be improved).
>
> Printing cryptic error codes has never been a good idea and is
> definitly not a "great" idea.
Agreed, I don't think we want to go down the path of just suppressing
some of these error messages, that's not helpful.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180718/f87fd88e/attachment.sig>
prev parent reply other threads:[~2018-07-18 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:09 [U-Boot] [RFC 1/2] env: Drop error messages when loading environment Sam Protsenko
2018-07-17 22:09 ` [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env Sam Protsenko
2018-07-18 6:23 ` Wolfgang Denk
2018-07-18 12:53 ` Tom Rini
2018-07-18 13:04 ` Sam Protsenko
2018-07-18 14:28 ` Tom Rini
2018-07-18 14:09 ` Wolfgang Denk
2018-07-19 12:52 ` Tom Rini
2018-07-19 13:12 ` Sam Protsenko
2018-07-19 19:52 ` Wolfgang Denk
2018-07-19 20:16 ` Sam Protsenko
2018-07-19 19:49 ` Wolfgang Denk
2018-07-18 6:19 ` [U-Boot] [RFC 1/2] env: Drop error messages when loading environment Wolfgang Denk
2018-07-18 12:50 ` Sam Protsenko
2018-07-18 12:51 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718125105.GD4609@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox