From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 18 Jul 2018 08:51:05 -0400 Subject: [U-Boot] [RFC 1/2] env: Drop error messages when loading environment In-Reply-To: <20180718061950.6BDAA240133@gemini.denx.de> References: <20180717220912.11358-1-semen.protsenko@linaro.org> <20180718061950.6BDAA240133@gemini.denx.de> Message-ID: <20180718125105.GD4609@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jul 18, 2018 at 08:19:50AM +0200, Wolfgang Denk wrote: > Dear Sam, > > In message <20180717220912.11358-1-semen.protsenko@linaro.org> you wrote: > > This is just a draft to discuss ideas related to "Make U-Boot log great > > again" thread. > > > > With this patch we will have something like this: > > > > Loading Environment from FAT... Failed (-5) > > Loading Environment from MMC... OK > > > > instead of this: > > > > Loading Environment from FAT... MMC: no card present > > ** Bad device mmc 0 ** > > Failed (-5) > > Loading Environment from MMC... OK > > Why do you think an error message "Failed (-5)" looks great? > > From a user's point of view, the "MMC: no card present" > is _much_ better (but of course it could still be improved). > > Printing cryptic error codes has never been a good idea and is > definitly not a "great" idea. Agreed, I don't think we want to go down the path of just suppressing some of these error messages, that's not helpful. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: