From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env
Date: Wed, 18 Jul 2018 08:53:51 -0400 [thread overview]
Message-ID: <20180718125351.GE4609@bill-the-cat> (raw)
In-Reply-To: <20180717220912.11358-2-semen.protsenko@linaro.org>
On Wed, Jul 18, 2018 at 01:09:12AM +0300, Sam Protsenko wrote:
> This is just a draft to discuss ideas related to "Make U-Boot log great
> again" thread.
>
> With this patch we will see something like:
>
> Loading Environment from FAT...
> --> MMC: no card present
> --> ** Bad device mmc 0 **
> --> Failed (-5)
> Loading Environment from MMC...
> --> OK
>
> instead of:
>
> Loading Environment from FAT... MMC: no card present
> ** Bad device mmc 0 **
> Failed (-5)
> Loading Environment from MMC... OK
So, I think maybe (and given Wolfgang's comments) we should think about
how the output might want to look, and how to get there without GD
changes. Perhaps:
Attempting to load Environment from FAT (do we have more easily
available info at this point?):
MMC: no card present
** Bad device mmc 0 **
Failed (-5)
Loading Environment from MMC...
Attempting to load Environment from MMC:
Succeeded
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180718/8c5f8bda/attachment.sig>
next prev parent reply other threads:[~2018-07-18 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:09 [U-Boot] [RFC 1/2] env: Drop error messages when loading environment Sam Protsenko
2018-07-17 22:09 ` [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env Sam Protsenko
2018-07-18 6:23 ` Wolfgang Denk
2018-07-18 12:53 ` Tom Rini [this message]
2018-07-18 13:04 ` Sam Protsenko
2018-07-18 14:28 ` Tom Rini
2018-07-18 14:09 ` Wolfgang Denk
2018-07-19 12:52 ` Tom Rini
2018-07-19 13:12 ` Sam Protsenko
2018-07-19 19:52 ` Wolfgang Denk
2018-07-19 20:16 ` Sam Protsenko
2018-07-19 19:49 ` Wolfgang Denk
2018-07-18 6:19 ` [U-Boot] [RFC 1/2] env: Drop error messages when loading environment Wolfgang Denk
2018-07-18 12:50 ` Sam Protsenko
2018-07-18 12:51 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718125351.GE4609@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox