public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] env: Don't print "Failed" error message
Date: Fri, 20 Jul 2018 15:29:43 +0200	[thread overview]
Message-ID: <20180720132943.AFDA124015D@gemini.denx.de> (raw)
In-Reply-To: <20180720131421.7136-2-semen.protsenko@linaro.org>

Dear Sam,

In message <20180720131421.7136-2-semen.protsenko@linaro.org> you wrote:
>
> +		if (!ret)
>  			printf("OK\n");
>  
>  		if (!ret)

Now we have two "if (!ret)" in sequence.  Make this one block,
please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Commitment, n.:      Commitment can be illustrated by a breakfast
of ham and eggs. The chicken was involved, the pig was committed.

  reply	other threads:[~2018-07-20 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 13:14 [U-Boot] [PATCH 0/2] env: Make environment loading log more clear Sam Protsenko
2018-07-20 13:14 ` [U-Boot] [PATCH 1/2] env: Don't print "Failed" error message Sam Protsenko
2018-07-20 13:29   ` Wolfgang Denk [this message]
2018-07-20 14:54     ` Sam Protsenko
2018-07-20 13:14 ` [U-Boot] [PATCH 2/2] disk: part: Don't show redundant " Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720132943.AFDA124015D@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox